Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix. KdocMethod should not raise warning on override fun #594

Merged
merged 4 commits into from
Nov 30, 2020

Conversation

aktsay6
Copy link
Collaborator

@aktsay6 aktsay6 commented Nov 30, 2020

What's done:

  • Fixed bugs

This pull request closes #551

### What's done:
  * Fixed bugs
@aktsay6 aktsay6 added the bug Something isn't working label Nov 30, 2020
@aktsay6 aktsay6 requested review from petertrr and kentr0w November 30, 2020 12:21
@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #594 (21b7f90) into master (2349037) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #594   +/-   ##
=========================================
  Coverage     80.84%   80.84%           
- Complexity     1704     1705    +1     
=========================================
  Files            87       87           
  Lines          4365     4365           
  Branches       1346     1346           
=========================================
  Hits           3529     3529           
  Misses          297      297           
  Partials        539      539           
Flag Coverage Δ Complexity Δ
unittests 80.84% <100.00%> (ø) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../org/cqfn/diktat/ruleset/rules/kdoc/KdocMethods.kt 90.19% <100.00%> (ø) 70.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2349037...21b7f90. Read the comment docs.

### What's done:
  * Fixed bugs
…ory(#551)' into bugfix/overriden-kdoc-not-mandatory(#551)
@aktsay6 aktsay6 merged commit 6d4a8ef into master Nov 30, 2020
@aktsay6 aktsay6 deleted the bugfix/overriden-kdoc-not-mandatory(#551) branch November 30, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make KDocs on overriden functions/properties not mandatory
2 participants