Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style guide #582

Merged
merged 5 commits into from
Nov 27, 2020
Merged

Code style guide #582

merged 5 commits into from
Nov 27, 2020

Conversation

petertrr
Copy link
Member

What's done:

  • Diktat code style guide generated

@petertrr
Code style guide
6e60313 
### What's done:
* Diktat code style guide generated
@petertrr petertrr requested a review from orchestr7 November 27, 2020 09:47
orchestr7
orchestr7 approved these changes Nov 27, 2020
View reviewed changes
Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Nov 27, 2020 •
edited
Loading

Codecov Report

Merging #582 (6299690) into master (b1b85e0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #582   +/-   ##
=========================================
  Coverage     80.73%   80.73%           
  Complexity     1702     1702           
=========================================
  Files            87       87           
  Lines          4345     4345           
  Branches       1340     1340           
=========================================
  Hits           3508     3508           
  Misses          299      299           
  Partials        538      538
Flag Coverage Δ Complexity Δ
unittests 80.73% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1b85e0...6299690. Read the comment docs.

@petertrr petertrr merged commit 5426cd4 into master Nov 27, 2020
@petertrr petertrr deleted the feature/code-style-guide-full branch November 27, 2020 09:55
@petertrr petertrr added the documentation Improvements or additions to documentation label Dec 17, 2020
@petertrr petertrr mentioned this pull request Dec 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orchestr7 orchestr7 orchestr7 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petertrr @orchestr7