-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mechanism to exclude files from check #563
Conversation
### What's done: * Logic in maven plugin * Logic in gradle plugin * Tests in gradle plugin * Fixes for metrics_yml
Codecov Report
@@ Coverage Diff @@
## master #563 +/- ##
============================================
- Coverage 81.68% 80.73% -0.95%
- Complexity 1641 1702 +61
============================================
Files 79 87 +8
Lines 4139 4345 +206
Branches 1307 1340 +33
============================================
+ Hits 3381 3508 +127
- Misses 229 299 +70
- Partials 529 538 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * Tests for maven plugin
### What's done: * Fixes
### What's done: * Fixes in gradle logic
diktat-gradle-plugin/src/main/kotlin/org/cqfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt
Show resolved
Hide resolved
diktat-gradle-plugin/src/main/kotlin/org/cqfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt
Outdated
Show resolved
Hide resolved
### What's done: * Fixes in gradle logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What's done:
This pull request closes #325 , also partially closes #543
Added excludes in maven plugin in diktat self-check.
I've tested excludes in gradle plugin manually.
Fixme
package
in metrcs_maser actually helps, or will it not finddiktat-common