Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mechanism to exclude files from check #563

Merged
merged 8 commits into from
Nov 26, 2020
Merged

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Nov 23, 2020

What's done:

  • Logic in maven plugin
  • Logic in gradle plugin
  • Tests in gradle plugin
  • Fixes for metrics_yml

This pull request closes #325 , also partially closes #543

Added excludes in maven plugin in diktat self-check.
I've tested excludes in gradle plugin manually.

Fixme

  • Update readmes
  • check if package in metrcs_maser actually helps, or will it not find diktat-common

### What's done:
* Logic in maven plugin
* Logic in gradle plugin
* Tests in gradle plugin
* Fixes for metrics_yml
@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #563 (ff1651f) into master (052bd9d) will decrease coverage by 0.94%.
The diff coverage is 84.84%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #563      +/-   ##
============================================
- Coverage     81.68%   80.73%   -0.95%     
- Complexity     1641     1702      +61     
============================================
  Files            79       87       +8     
  Lines          4139     4345     +206     
  Branches       1307     1340      +33     
============================================
+ Hits           3381     3508     +127     
- Misses          229      299      +70     
- Partials        529      538       +9     
Flag Coverage Δ Complexity Δ
unittests 80.73% <84.84%> (-0.95%) 0.00 <39.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...lin/org/cqfn/diktat/plugin/maven/DiktatBaseMojo.kt 7.14% <0.00%> (ø) 2.00 <0.00> (?)
...at-rules/src/main/kotlin/generated/WarningNames.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
...fn/diktat/ruleset/rules/kdoc/CommentsFormatting.kt 69.79% <ø> (-0.21%) 76.00 <0.00> (-1.00)
...lin/org/cqfn/diktat/ruleset/rules/PackageNaming.kt 93.75% <33.33%> (-1.19%) 32.00 <0.00> (ø)
...qfn/diktat/plugin/gradle/DiktatJavaExecTaskBase.kt 76.92% <72.72%> (ø) 6.00 <0.00> (?)
.../cqfn/diktat/ruleset/rules/BlockStructureBraces.kt 83.92% <85.71%> (+0.11%) 53.00 <0.00> (ø)
...ktat/ruleset/rules/AvoidEmptyPrimaryConstructor.kt 90.00% <90.00%> (ø) 8.00 <8.00> (?)
...iktat/ruleset/rules/ImplicitBackingPropertyRule.kt 93.75% <93.75%> (ø) 23.00 <23.00> (?)
...n/org/cqfn/diktat/plugin/gradle/DiktatExtension.kt 100.00% <100.00%> (ø) 5.00 <1.00> (?)
...rg/cqfn/diktat/plugin/gradle/DiktatGradlePlugin.kt 100.00% <100.00%> (ø) 2.00 <0.00> (?)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e91e26...ff1651f. Read the comment docs.

### What's done:
* Tests for maven plugin
### What's done:
* Fixes
@petertrr petertrr marked this pull request as ready for review November 24, 2020 09:09
@petertrr petertrr requested a review from orchestr7 November 24, 2020 09:09
@petertrr petertrr marked this pull request as draft November 24, 2020 09:56
### What's done:
* Fixes in gradle logic
@petertrr petertrr marked this pull request as ready for review November 24, 2020 12:32
Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petertrr petertrr merged commit 89873bb into master Nov 26, 2020
@petertrr petertrr deleted the feature/excludes#325 branch November 26, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for maven plugin Mechanism to exclude files from check
2 participants