Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diktat-examples refactoring and CI #548

Merged
merged 23 commits into from
Nov 20, 2020
Merged

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Nov 18, 2020

This pull request closes #517

  • Examples are corrected, they now use diktat plugins with correct versions
  • All versions are updated from release.yml
  • Functional tests run against exmples

### What's done:
* Updated maven examples, added gradle-groovy examples
* Updated functional test
### What's done:
* Updated versions
* Updated functional_tests.yml
* Removed root build.gradle
@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #548 (83f8df8) into master (718c678) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #548   +/-   ##
=========================================
  Coverage     81.93%   81.93%           
  Complexity     1637     1637           
=========================================
  Files            78       78           
  Lines          4123     4123           
  Branches       1302     1302           
=========================================
  Hits           3378     3378           
  Misses          219      219           
  Partials        526      526           
Flag Coverage Δ Complexity Δ
unittests 81.93% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 718c678...16ba571. Read the comment docs.

### What's done:
* Updated versions
### What's done:
* Experiment with matrix build
### What's done:
* Refactoring
### What's done:
* Refactoring
### What's done:
* Refactoring
### What's done:
* Refactoring
### What's done:
* Refactoring
### What's done:
* Refactoring
### What's done:
* Refactoring
### What's done:
* Refactoring
### What's done:
* Refactoring
### What's done:
* Refactoring
### What's done:
* Refactoring
### What's done:
* Refactoring
### What's done:
* Refactoring
### What's done:
* Refactoring
### What's done:
* Refactoring
### What's done:
* Refactoring
### What's done:
* Refactoring
@petertrr petertrr marked this pull request as ready for review November 19, 2020 14:32
Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@orchestr7
Copy link
Member

btw - do we keep examples like a separate project, not a sub-module?

@petertrr
Copy link
Member Author

btw - do we keep examples like a separate project, not a sub-module?

yes, it's just a folder

@petertrr petertrr merged commit bbb494b into master Nov 20, 2020
@petertrr petertrr deleted the feature/examples-refactoring branch November 20, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add diktat-gradle-plugin to functional tests after release
2 participants