Bugfix. Newline at the beginning of code block is not removed if there are more than one #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Fixed bugs
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
=========================================
Coverage 81.68% 81.69%
- Complexity 1641 1665 +24
=========================================
Files 79 83 +4
Lines 4139 4211 +72
Branches 1307 1314 +7
=========================================
+ Hits 3381 3440 +59
- Misses 229 238 +9
- Partials 529 533 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * Fixed bugs
This reverts commit fdece79.
petertrr
approved these changes
Nov 23, 2020
| @@ -53,7 +56,10 @@ class BlankLinesRule(private val configRules: List<RulesConfig>) : Rule("blank-l | |||
|
|
|||
| private fun handleTooManyBlankLines(node: ASTNode) { | |||
| TOO_MANY_BLANK_LINES.warnAndFix(configRules, emitWarn, isFixMode, "do not use more than two consecutive blank lines", node.startOffset, node) { | |||
| node.leaveExactlyNumNewLines(2) | |||
| if (node.treeParent.findAllNodesWithSpecificType(WHITE_SPACE).first() == node) | |||
There was a problem hiding this comment.
Isn't findChildByType enough here?
### What's done: * Fixed bugs
petertrr
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #519