Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewed changes for the Code Style guide #521

Merged
merged 5 commits into from
Nov 26, 2020

Conversation

vtchem
Copy link
Contributor

@vtchem vtchem commented Nov 13, 2020

What's done:

Edited the material and requested review.

vtchem and others added 2 commits November 13, 2020 15:49
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #521 (d48d4e9) into master (89873bb) will increase coverage by 0.95%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #521      +/-   ##
============================================
+ Coverage     80.73%   81.68%   +0.95%     
+ Complexity     1702     1652      -50     
============================================
  Files            87       83       -4     
  Lines          4345     4205     -140     
  Branches       1340     1312      -28     
============================================
- Hits           3508     3435      -73     
+ Misses          299      238      -61     
+ Partials        538      532       -6     
Flag Coverage Δ Complexity Δ
unittests 81.68% <ø> (+0.95%) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...g/cqfn/diktat/ruleset/utils/FunctonASTNodeUtils.kt 69.23% <0.00%> (-2.20%) 0.00% <0.00%> (ø%)
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt 82.32% <0.00%> (-0.94%) 0.00% <0.00%> (ø%)
...qfn/diktat/ruleset/rules/classes/SingleInitRule.kt 77.77% <0.00%> (-0.69%) 10.00% <0.00%> (-6.00%)
...org/cqfn/diktat/ruleset/rules/kdoc/KdocComments.kt 81.98% <0.00%> (-0.32%) 57.00% <0.00%> (-4.00%)
...rg/cqfn/diktat/ruleset/rules/files/NewlinesRule.kt 83.78% <0.00%> (-0.18%) 104.00% <0.00%> (-6.00%)
.../cqfn/diktat/ruleset/rules/BlockStructureBraces.kt 83.80% <0.00%> (-0.12%) 53.00% <0.00%> (ø%)
...cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt 97.26% <0.00%> (-0.08%) 8.00% <0.00%> (ø%)
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt 98.31% <0.00%> (-0.03%) 10.00% <0.00%> (ø%)
...tlin/org/cqfn/diktat/ruleset/utils/ASTConstants.kt 100.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
.../cqfn/diktat/ruleset/rules/files/BlankLinesRule.kt 100.00% <0.00%> (ø) 12.00% <0.00%> (-1.00%)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89873bb...0cb8328. Read the comment docs.

…Viktor_Guide_Review

� Conflicts:
�	info/guide/guide-chapter-1.md
�	info/guide/guide-chapter-2.md
�	info/guide/guide-chapter-3.md
�	info/guide/guide-chapter-4.md
�	info/guide/guide-chapter-6.md
### What's done:
Review notes
Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@orchestr7 orchestr7 merged commit b1b85e0 into master Nov 26, 2020
@petertrr petertrr deleted the feature/Viktor_Guide_Review branch November 27, 2020 11:07
@petertrr petertrr added the documentation Improvements or additions to documentation label Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants