Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix. NPE in TrivialPropertyAccessors rule #512

Merged
merged 6 commits into from
Nov 11, 2020

Conversation

aktsay6
Copy link
Collaborator

@aktsay6 aktsay6 commented Nov 11, 2020

TrivialPropertyAccessors rule throws NPE

This pull request closes #511

### What's done:
  * Fixed bugs
### What's done:
  * Fixed bugs
@aktsay6 aktsay6 added the bug Something isn't working label Nov 11, 2020
@aktsay6 aktsay6 requested review from petertrr and kentr0w November 11, 2020 10:02
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #512 (8da6f12) into master (dad0572) will decrease coverage by 0.04%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #512      +/-   ##
============================================
- Coverage     81.80%   81.76%   -0.05%     
- Complexity     1547     1550       +3     
============================================
  Files            73       73              
  Lines          3892     3894       +2     
  Branches       1242     1245       +3     
============================================
  Hits           3184     3184              
  Misses          210      210              
- Partials        498      500       +2     
Flag Coverage Δ Complexity Δ
unittests 81.76% <40.00%> (-0.05%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...n/diktat/ruleset/rules/TrivialPropertyAccessors.kt 79.31% <40.00%> (-5.88%) 18.00 <0.00> (+3.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dad0572...8da6f12. Read the comment docs.

@aktsay6 aktsay6 marked this pull request as ready for review November 11, 2020 10:10
### What's done:
  * Fixed bugs
@aktsay6 aktsay6 requested a review from petertrr November 11, 2020 12:18
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aktsay6 aktsay6 merged commit 4e7d838 into master Nov 11, 2020
@petertrr petertrr deleted the bugfix/npe-trivial-accessors(#511) branch November 18, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE in TrivialPropertyAccessors rule
2 participants