Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix. Do not check KDoc on method main #509

Merged
merged 3 commits into from
Nov 11, 2020
Merged

Conversation

aktsay6
Copy link
Collaborator

@aktsay6 aktsay6 commented Nov 10, 2020

What's done

Fixed bug that MISSING_KDOC_TOP_LEVEL still checks fun main for documentation

This pull request closes #89

### What's done:
  * Fixed bugs
### What's done:
  * Fixed bugs
@aktsay6 aktsay6 requested review from petertrr and kentr0w November 10, 2020 13:51
@aktsay6 aktsay6 added the bug Something isn't working label Nov 10, 2020
@aktsay6 aktsay6 marked this pull request as ready for review November 10, 2020 13:55
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #509 (1ae7c86) into master (6ead4fc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #509   +/-   ##
=========================================
  Coverage     81.80%   81.80%           
- Complexity     1543     1547    +4     
=========================================
  Files            73       73           
  Lines          3891     3892    +1     
  Branches       1242     1242           
=========================================
+ Hits           3183     3184    +1     
  Misses          210      210           
  Partials        498      498           
Flag Coverage Δ Complexity Δ
unittests 81.80% <100.00%> (+<0.01%) 0.00 <3.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...org/cqfn/diktat/ruleset/rules/kdoc/KdocComments.kt 81.98% <100.00%> (+0.16%) 57.00 <3.00> (+4.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ead4fc...1ae7c86. Read the comment docs.

Comment on lines 287 to 290
if (node.elementType == FUN) {
return node.isStandardMethod()
}
return false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (node.elementType == FUN) {
return node.isStandardMethod()
}
return false
return node.elementType == FUN &&
node.isStandardMethod()

### What's done:
  * Fixed bugs
@aktsay6 aktsay6 merged commit 48eec27 into master Nov 11, 2020
@aktsay6 aktsay6 deleted the bugfix/kdoc-on-main(#89) branch November 11, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not check KDoc on method main
2 participants