Fixes for chapters 4-5 after native review. #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: 0) Script for generating code style file 1) 6th chapter was not reviewed, so just a new file with this chapter is created
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
=========================================
Coverage 81.83% 81.83%
Complexity 1501 1501
=========================================
Files 71 71
Lines 3765 3765
Branches 1209 1209
=========================================
Hits 3081 3081
Misses 210 210
Partials 474 474
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
petertrr
approved these changes
Nov 6, 2020
petertrr
reviewed
Nov 6, 2020
| .sortedBy { it.nameWithoutExtension.replace(GUIDE_PATTERN, "").toInt() } | ||
| .map { it.readLines() } | ||
| .flatten() | ||
| .joinToString("\n") |
There was a problem hiding this comment.
Suggested change
| .joinToString("\n") | |
| .joinToString(System.lineSeparator) |
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done: