Rule 6.1.4 several init blocks are redundant and generally should not be used in your class #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Initial implementation * Fixed typos in code style
# Conflicts: # diktat-analysis.yml # diktat-rules/src/main/kotlin/generated/WarningNames.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt # diktat-rules/src/main/resources/diktat-analysis-huawei.yml # diktat-rules/src/main/resources/diktat-analysis.yml # info/available-rules.md
### What's done: * paragraph6 -> chapter6
### What's done: * Fixes
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
============================================
- Coverage 81.98% 81.91% -0.07%
- Complexity 1451 1461 +10
============================================
Files 70 71 +1
Lines 3624 3689 +65
Branches 1159 1178 +19
============================================
+ Hits 2971 3022 +51
Misses 202 202
- Partials 451 465 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
aktsay6
reviewed
Oct 27, 2020
### What's done: * More logic
### What's done: * More logic
### What's done: * More logic
orchestr7
reviewed
Nov 2, 2020
| package test.chapter6.init_blocks | ||
|
|
||
| class Example { | ||
| init { println("Lorem ipsum") } |
There was a problem hiding this comment.
@petertrr I have started thinking right now that there is a possibility to break the code here.
If someone will do the following:
init { println(1) }
val a = "".also {
println(3)
}
init { println(2) }
We will break expected print chain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #440
Actions checklist
Fixme
initblocks