Codestyle, chapter 6 #421
Merged
Codestyle, chapter 6 #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: 1) Added class related rules
orchestr7
commented
Oct 18, 2020
| @@ -10,7 +10,8 @@ | |||
| | [2 Comments](#c2) | [Kdoc](#c2.1), [File header](#c2.2), [Function header comments](#c2.3), [Code comments](#c2.4) | | |||
| | [3 General format](#c3) | [File-related rules](#c3.1), [Indentation](#c3.2), [Empty blocks](#c3.3), [Line width](#c3.4), [Line breaks (newlines)](#c3.5), [Blank lines](#c3.6), [Horiznotal alignment](#c3.7), [Enumerations](#c3.8), [Variable declaration](#c3.9), [When expression](#c3.10), [Annotations](#c3.11), [Comment layout](#c3.12), [Modifiers](#c3.13), [Strings](#c3.14)| | |||
| | [4 Variables and types](#c4) | [Variables](#c4.1), [Types](#c4.2), [Null safety and variable declarations](#4.3)| | |||
| | [5 Functions](#c5) | [Function design](#c5.1) [Function parameters](#c5.2)| | |||
| | [5 Functions](#c5) | [Function design](#c5.1), [Function parameters](#c5.2)| | |||
| | [6 Classes](#c6) | [Classes](#c6.1), [Interfaces](#c6.2), [Objects](#c6.3)| | |||
There was a problem hiding this comment.
have no ideas by for now about 6.2. and 6.3, but I will think
already written too many rules ...
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
============================================
+ Coverage 82.49% 82.71% +0.21%
- Complexity 1347 1359 +12
============================================
Files 65 66 +1
Lines 3314 3401 +87
Branches 1056 1078 +22
============================================
+ Hits 2734 2813 +79
+ Misses 179 172 -7
- Partials 401 416 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petertrr
approved these changes
Oct 19, 2020
| ``` | ||
|
|
||
| ### <a name="r6.1.2"></a> Rule 6.1.2: Prefer data classes instead of classes without any functional logic | ||
| Some people say that data class - is a code smell, but in case you really need to use it and your is becoming more simple because of that - |
There was a problem hiding this comment.
Suggested change
| Some people say that data class - is a code smell, but in case you really need to use it and your is becoming more simple because of that - | |
| Some people say that data class - is a code smell, but in case you really need to use it and your code is becoming more simple because of that - |
I thought data classes are one of the killer-features of kotlin, do we really need to mention in our code style that it is considered a code smell?
There was a problem hiding this comment.
Yeah, that's why I say "some people" say :))
https://refactoring.guru/smells/data-class
| } | ||
| ``` | ||
|
|
||
| In this case the name of backing property (`_table`) should be the same to the name of real property (`table`), but should have underscore (`_`) prefix. |
There was a problem hiding this comment.
Will this clash with requirements of identifier naming chapter?
There was a problem hiding this comment.
yeah, hm, that is true - I will mention it
### What's done: Review notes
### What's done: Review notes
…o feature/chapter6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done: