Fixing issue in WhiteSpaceRule #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Changed logic * Added tests
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
============================================
- Coverage 82.62% 82.50% -0.13%
- Complexity 1343 1346 +3
============================================
Files 65 65
Lines 3298 3298
Branches 1055 1053 -2
============================================
- Hits 2725 2721 -4
- Misses 177 178 +1
- Partials 396 399 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
orchestr7
reviewed
Oct 16, 2020
| @@ -15,3 +15,8 @@ class Example : SuperExample { | |||
| when (expression) { } | |||
| } | |||
| } | |||
|
|
|||
| data class Example( | |||
There was a problem hiding this comment.
same bug was with functions?
now it fixes foo ()?
There was a problem hiding this comment.
Thanks, this case was missing in tests. Added.
But diktat fixes it already.
### What's done: * Added tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
This pull request closes #405