Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated calculateLineColByOffset methods from Ktlint #394

Merged
merged 4 commits into from
Oct 21, 2020

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Oct 13, 2020

What's done:

Copy-paste methods
closes #386

@kentr0w kentr0w added the bug Something isn't working label Oct 13, 2020
@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #394 into master will increase coverage by 0.01%.
The diff coverage is 86.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #394      +/-   ##
============================================
+ Coverage     82.69%   82.71%   +0.01%     
  Complexity     1359     1359              
============================================
  Files            65       66       +1     
  Lines          3364     3401      +37     
  Branches       1070     1078       +8     
============================================
+ Hits           2782     2813      +31     
- Misses          171      172       +1     
- Partials        411      416       +5     
Flag Coverage Δ Complexity Δ
#unittests 82.71% <86.36%> (+0.01%) 1359.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...cqfn/diktat/ruleset/utils/PositionInTextLocator.kt 83.33% <83.33%> (ø) 0.00 <0.00> (?)
...kotlin/org/cqfn/diktat/ruleset/rules/LineLength.kt 84.15% <100.00%> (ø) 75.00 <0.00> (ø)
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt 82.15% <100.00%> (+0.08%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8e8b2d...33c7c4b. Read the comment docs.

### What's done:
    Renamed variables and fixed bugs
…lateLineColByOffset

# Conflicts:
#	diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt
@kentr0w kentr0w merged commit 2175cb9 into master Oct 21, 2020
@kentr0w kentr0w deleted the bugfix/remove-calculateLineColByOffset branch October 21, 2020 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

calculateLineColByOffset is deprecated in ktlint 0.39
2 participants