Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kotlinx.serialization instead of jackson #393

Merged
merged 18 commits into from
Oct 14, 2020

Conversation

petertrr
Copy link
Member

No description provided.

### What's done:
* Updated kotlin
* Updated ktlint
* Changed kotlin-stdlib dependency to kotlin-stdlib-jdk8
* pom.xml cleanup
* Fixed kotlin compiler warnings
### What's done:
* Moved from jackson to kotlinx.serialization and kaml
### What's done:
* detekt code style
### What's done:
* Fixes
### What's done:
* Fixes
### What's done:
* Try to rollback to stdlib from stdlib-jdk8
### What's done:
This reverts commit 75dae5b
### What's done:
* Use old methods for min
### What's done:
* Compile with api version 1.3
### What's done:
* Use current kotlin api version
### What's done:
* Use new methods instead of deprecated
### What's done:
* Use apiVersion 1.3
…/kotlinx-serialization

# Conflicts:
#	diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/identifiers/LocalVariablesRule.kt
#	diktat-test-framework/pom.xml
@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #393 into master will decrease coverage by 0.01%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #393      +/-   ##
============================================
- Coverage     82.55%   82.54%   -0.02%     
  Complexity     1340     1340              
============================================
  Files            65       65              
  Lines          3251     3249       -2     
  Branches       1042     1043       +1     
============================================
- Hits           2684     2682       -2     
  Misses          177      177              
  Partials        390      390              
Flag Coverage Δ Complexity Δ
#unittests 82.54% <40.00%> (-0.02%) 1340.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...n/kotlin/org/cqfn/diktat/common/cli/CliArgument.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...fn/diktat/common/config/rules/RulesConfigReader.kt 35.71% <50.00%> (-7.15%) 4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 819b631...f26c4f0. Read the comment docs.

Copy link
Collaborator

@kentr0w kentr0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from feature/kotlin-1.4 to master October 14, 2020 08:34
@petertrr petertrr marked this pull request as ready for review October 14, 2020 08:36
@petertrr petertrr merged commit bf1b26a into master Oct 14, 2020
@petertrr petertrr deleted the feature/kotlinx-serialization branch October 14, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants