Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions/checkout requirement to v2.3.3 #367

Merged
merged 6 commits into from
Oct 15, 2020

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 6, 2020

Updates the requirements on actions/checkout to permit the latest version.

Release notes

Sourced from actions/checkout's releases.

v2.3.3

Changelog

Sourced from actions/checkout's changelog.

Changelog

v2.3.1

v2.3.0

v2.2.0

v2.1.1

  • Changes to support GHES (here and here)

v2.1.0

v2.0.0

v2 (beta)

  • Improved fetch performance
    • The default behavior now fetches only the SHA being checked-out
  • Script authenticated git commands
    • Persists with.token in the local git config
    • Enables your scripts to run authenticated git commands
    • Post-job cleanup removes the token
    • Coming soon: Opt out by setting with.persist-credentials to false
  • Creates a local branch
    • No longer detached HEAD when checking out a branch
    • A local branch is created with the corresponding upstream branch set
  • Improved layout

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code labels Oct 6, 2020
@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #367 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #367   +/-   ##
=========================================
  Coverage     82.54%   82.54%           
  Complexity     1340     1340           
=========================================
  Files            65       65           
  Lines          3249     3249           
  Branches       1043     1043           
=========================================
  Hits           2682     2682           
  Misses          177      177           
  Partials        390      390           
Flag Coverage Δ Complexity Δ
#unittests 82.54% <ø> (ø) 1340.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddc478d...af1a187. Read the comment docs.

@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/checkout-v2.3.3 branch from d1af7bc to 2688c12 Compare October 6, 2020 11:34
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/checkout-v2.3.3 branch from 2688c12 to 6362406 Compare October 6, 2020 19:36
@petertrr
Copy link
Member

petertrr commented Oct 8, 2020

Seems like with checkout@v2 codecov receives hash of temporary merge commit, not the hash of last commit in source branch. This needs some investigation.
Related discussion - actions/checkout#237
Edit: for two commits in this PR everything seems to be fine: action/checkout logs that it merges branches, but codecov receives report for commit from source branch.
Edit 2: in commit 935f788 it seems to once again show incorrect behavior

Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm when they will fix issues

* Revert checkout action to v1 due to problems with codecov reports
@petertrr
Copy link
Member

lgtm when they will fix issues

I'll keep version 1 in build_and_test where we face issues and update in other workflows, where merge commit doesn't matter.

@petertrr petertrr merged commit 5937a57 into master Oct 15, 2020
@petertrr petertrr deleted the dependabot/github_actions/actions/checkout-v2.3.3 branch October 15, 2020 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants