Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule 5.2.2 parameters size #359

Merged
merged 7 commits into from
Oct 6, 2020
Merged

Rule 5.2.2 parameters size #359

merged 7 commits into from
Oct 6, 2020

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Oct 5, 2020

What's done:

Implemented rule

Actions checklist

### What's done:
   Implemented rule
@kentr0w kentr0w added the enhancement New feature or request label Oct 5, 2020
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #359 into master will increase coverage by 0.01%.
The diff coverage is 86.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #359      +/-   ##
============================================
+ Coverage     82.79%   82.81%   +0.01%     
- Complexity     1182     1187       +5     
============================================
  Files            58       59       +1     
  Lines          2935     2950      +15     
  Branches        930      934       +4     
============================================
+ Hits           2430     2443      +13     
  Misses          169      169              
- Partials        336      338       +2     
Flag Coverage Δ Complexity Δ
#unittests 82.81% <86.66%> (+0.01%) 1187.00 <5.00> (+5.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...at-rules/src/main/kotlin/generated/WarningNames.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
...cqfn/diktat/ruleset/rules/FunctionArgumentsSize.kt 84.61% <84.61%> (ø) 5.00 <5.00> (?)
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt 96.96% <100.00%> (+0.03%) 9.00 <0.00> (ø)
...cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt 97.95% <100.00%> (+0.04%) 3.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dbf1b0...a39c29a. Read the comment docs.

### What's done:
   added suppress
### What's done:
   Added new line
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just suggest to change some names.

### What's done:
    Renamed some fields
### What's done:
    Changed test
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please also suppress TOO_MANY_PARAMETERS warning in Warnings.kt

### What's done:
    Added suppress into Warnings.kt
@kentr0w kentr0w merged commit 6434c2a into master Oct 6, 2020
@kentr0w kentr0w deleted the feature/rule-5.2.2 branch October 6, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule 5.2.2 Number of parameters of function should be limited to 5
2 participants