-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule 5.2.2 parameters size #359
Conversation
### What's done: Implemented rule
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
============================================
+ Coverage 82.79% 82.81% +0.01%
- Complexity 1182 1187 +5
============================================
Files 58 59 +1
Lines 2935 2950 +15
Branches 930 934 +4
============================================
+ Hits 2430 2443 +13
Misses 169 169
- Partials 336 338 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: added suppress
### What's done: Added new line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, just suggest to change some names.
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/FunctionArgumentsSize.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/FunctionArgumentsSize.kt
Outdated
Show resolved
Hide resolved
### What's done: Renamed some fields
### What's done: Changed test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please also suppress TOO_MANY_PARAMETERS
warning in Warnings.kt
### What's done: Added suppress into Warnings.kt
What's done:
Implemented rule
Actions checklist