Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving variable search mechanism #352

Merged
merged 6 commits into from
Oct 12, 2020
Merged

Conversation

orchestr7
Copy link
Member

What's done:

  1. Adding mechanism for searching assignments of VARs
  2. Moving all usages to new utilities of searching variables

### What's done:
1) Adding mechanism for searching assignments of VARs
2) Moving all usages to new utilities of searching variables
@orchestr7 orchestr7 force-pushed the feature/variables-search branch from 0fc0f73 to 0664e2a Compare October 5, 2020 00:44
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #352 into master will increase coverage by 0.09%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #352      +/-   ##
============================================
+ Coverage     83.00%   83.09%   +0.09%     
- Complexity     1263     1289      +26     
============================================
  Files            62       64       +2     
  Lines          3124     3147      +23     
  Branches        993      999       +6     
============================================
+ Hits           2593     2615      +22     
+ Misses          169      168       -1     
- Partials        362      364       +2     
Flag Coverage Δ Complexity Δ
#unittests 83.09% <85.71%> (+0.09%) 1289.00 <33.00> (+26.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt 82.74% <ø> (-0.18%) 0.00 <0.00> (ø)
...at/ruleset/rules/identifiers/LocalVariablesRule.kt 91.66% <66.66%> (-0.40%) 24.00 <2.00> (-8.00)
...eset/utils/search/VariablesWithAssignmentSearch.kt 78.57% <78.57%> (ø) 6.00 <6.00> (?)
...qfn/diktat/ruleset/utils/search/VariablesSearch.kt 86.20% <86.20%> (ø) 18.00 <18.00> (?)
...cqfn/diktat/ruleset/rules/ImmutableValNoVarRule.kt 88.88% <86.66%> (+3.17%) 8.00 <0.00> (+3.00)
...in/org/cqfn/diktat/ruleset/rules/files/FileSize.kt 67.85% <100.00%> (+1.19%) 8.00 <0.00> (ø)
...fn/diktat/ruleset/rules/files/FileStructureRule.kt 57.89% <100.00%> (+0.75%) 19.00 <0.00> (ø)
.../ruleset/utils/search/VariablesWithUsagesSearch.kt 100.00% <100.00%> (ø) 7.00 <7.00> (?)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1303570...a462d64. Read the comment docs.

### What's done:
1) Review notes
@orchestr7 orchestr7 added the enhancement New feature or request label Oct 11, 2020
@orchestr7 orchestr7 mentioned this pull request Oct 11, 2020
5 tasks
### What's done:
1) Detekt fixes
@orchestr7 orchestr7 merged commit d88c1ba into master Oct 12, 2020
@petertrr petertrr deleted the feature/variables-search branch October 14, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A lot of messages Not able to find a node with type ... after ... during tests
2 participants