-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving variable search mechanism #352
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: 1) Adding mechanism for searching assignments of VARs 2) Moving all usages to new utilities of searching variables
0fc0f73
to
0664e2a
Compare
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
============================================
+ Coverage 83.00% 83.09% +0.09%
- Complexity 1263 1289 +26
============================================
Files 62 64 +2
Lines 3124 3147 +23
Branches 993 999 +6
============================================
+ Hits 2593 2615 +22
+ Misses 169 168 -1
- Partials 362 364 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petertrr
reviewed
Oct 5, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt
Show resolved
Hide resolved
petertrr
reviewed
Oct 5, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/utils/search/VariablesSearch.kt
Outdated
Show resolved
Hide resolved
...-rules/src/main/kotlin/org/cqfn/diktat/ruleset/utils/search/VariablesWithAssignmentSearch.kt
Outdated
Show resolved
Hide resolved
### What's done: 1) Review notes
5 tasks
### What's done: 1) Review notes
petertrr
approved these changes
Oct 12, 2020
### What's done: 1) Detekt fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done: