Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug in functional_tests.yml #345

Merged
merged 4 commits into from
Sep 30, 2020
Merged

Conversation

aktsay6
Copy link
Collaborator

@aktsay6 aktsay6 commented Sep 30, 2020

What's done

  • Fixed bug with escape character

This pull request closes #344

Actions checklist

  • Implemented Rule, added Warnings
  • Added tests on checks
  • Added tests on fixers
  • Updated diktat-analysis.yml
  • Updated available-rules.md

@aktsay6 aktsay6 added the bug Something isn't working label Sep 30, 2020
@aktsay6 aktsay6 requested a review from petertrr September 30, 2020 08:52
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #345 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #345   +/-   ##
=========================================
  Coverage     81.77%   81.77%           
  Complexity     1102     1102           
=========================================
  Files            54       54           
  Lines          2798     2798           
  Branches        890      890           
=========================================
  Hits           2288     2288           
  Misses          183      183           
  Partials        327      327           
Flag Coverage Δ Complexity Δ
#unittests 81.77% <ø> (ø) 1102.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e51cd3...9f23762. Read the comment docs.

Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maven command should be
mvn -B compile antrun:run@functional-test > out
I think

Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aktsay6 aktsay6 merged commit 0270855 into master Sep 30, 2020
@petertrr petertrr deleted the bugfix/functional-test-bug branch October 1, 2020 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in functional testing
2 participants