-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule 5.1.1: Avoid too long functions, no more than 30 lines (non-empty, non-comment) #341
Conversation
### What's done: Made rule
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
============================================
+ Coverage 82.82% 82.86% +0.03%
- Complexity 1132 1142 +10
============================================
Files 56 57 +1
Lines 2836 2860 +24
Branches 908 915 +7
============================================
+ Hits 2349 2370 +21
Misses 162 162
- Partials 325 328 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/FunctionLength.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/FunctionLength.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt
Outdated
Show resolved
Hide resolved
### What's done: Simplified code
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/FunctionLength.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt
Outdated
Show resolved
Hide resolved
### What's done: Fixed bugs after review
…ction # Conflicts: # diktat-rules/src/main/resources/diktat-analysis.yml
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/FunctionLength.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/utils/StringUtils.kt
Outdated
Show resolved
Hide resolved
### What's done: Fixed bugs after review Added one more config
### What's done: Added suppress
### What's done: Added suppress
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/FunctionLength.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/FunctionLength.kt
Outdated
Show resolved
Hide resolved
### What's done: Fixed bug after review
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter5/FunctionLengthWarnTest.kt
Outdated
Show resolved
Hide resolved
### What's done: Fixed bug after review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/FunctionLength.kt
Outdated
Show resolved
Hide resolved
### What's done: Fixed bugs
### What's done: Fixed bugs
Actions checklist