Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule 5.1.1: Avoid too long functions, no more than 30 lines (non-empty, non-comment) #341

Merged
merged 11 commits into from
Oct 2, 2020

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Sep 29, 2020

Actions checklist

### What's done:
    Made rule
@kentr0w kentr0w added the enhancement New feature or request label Sep 29, 2020
@kentr0w kentr0w requested review from petertrr and aktsay6 September 29, 2020 15:09
@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #341 into master will increase coverage by 0.03%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #341      +/-   ##
============================================
+ Coverage     82.82%   82.86%   +0.03%     
- Complexity     1132     1142      +10     
============================================
  Files            56       57       +1     
  Lines          2836     2860      +24     
  Branches        908      915       +7     
============================================
+ Hits           2349     2370      +21     
  Misses          162      162              
- Partials        325      328       +3     
Flag Coverage Δ Complexity Δ
#unittests 82.86% <85.71%> (+0.03%) 1142.00 <10.00> (+10.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...at-rules/src/main/kotlin/generated/WarningNames.kt 0.00% <ø> (ø) 0.00 <0.00> (ø)
...tlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt 82.82% <83.33%> (+0.17%) 0.00 <0.00> (ø)
...in/org/cqfn/diktat/ruleset/rules/FunctionLength.kt 85.00% <85.00%> (ø) 10.00 <10.00> (?)
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt 96.90% <100.00%> (+0.03%) 9.00 <0.00> (ø)
...cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt 97.87% <100.00%> (+0.04%) 3.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a38311...f6b1b45. Read the comment docs.

### What's done:
   Simplified code
### What's done:
   Fixed bugs after review
…ction

# Conflicts:
#	diktat-rules/src/main/resources/diktat-analysis.yml
### What's done:
   Fixed bugs after review
   Added one more config
### What's done:
   Added suppress
### What's done:
   Added suppress
### What's done:
   Fixed bug after review
### What's done:
  Fixed bug after review
Copy link
Member

@petertrr petertrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

### What's done:
    Fixed bugs
### What's done:
    Fixed bugs
@kentr0w kentr0w merged commit e8690c9 into master Oct 2, 2020
@kentr0w kentr0w deleted the rule-5.1.1-long-function branch October 2, 2020 12:06
@orchestr7 orchestr7 changed the title Rule 5.1.1 Rule 5.1.1: Avoid too long functions, no more than 30 lines (non-empty, non-comment) Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule 5.1.1 Avoid too long functions, no more than 30 lines (non-empty, non-comment)
2 participants