Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added handling of annotated properties to BLANK_LINE_BETWEEN_PROPERTIES #331

Merged
merged 5 commits into from
Sep 28, 2020

Conversation

petertrr
Copy link
Member

What's done:

  • Updated logic
  • Added tests
  • Removed old configs

This pull request closes #282

### What's done:
* Updated logic
* Added tests
* Removed old configs
@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #331 into master will increase coverage by 0.04%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #331      +/-   ##
============================================
+ Coverage     81.73%   81.78%   +0.04%     
- Complexity     1071     1075       +4     
============================================
  Files            53       53              
  Lines          2760     2767       +7     
  Branches        873      876       +3     
============================================
+ Hits           2256     2263       +7     
  Misses          183      183              
  Partials        321      321              
Flag Coverage Δ Complexity Δ
#unittests 81.78% <91.66%> (+0.04%) 1075.00 <10.00> (+4.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ktat/ruleset/rules/ClassLikeStructuresOrderRule.kt 82.43% <91.66%> (+1.83%) 30.00 <10.00> (+4.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f5729b...50bce0a. Read the comment docs.

@petertrr petertrr changed the title Added handling of annotated properties to BLANK_LINES_BEFORE_PROPERTIES Added handling of annotated properties to BLANK_LINE_BETWEEN_PROPERTIES Sep 28, 2020
@petertrr petertrr requested review from aktsay6 and kentr0w September 28, 2020 11:36
Copy link
Collaborator

@kentr0w kentr0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petertrr petertrr merged commit f8c2c4f into master Sep 28, 2020
@petertrr petertrr deleted the bugfix/properties-declaration#282 branch September 28, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BLANK_LINE_BETWEEN_PROPERTIES should allow blank line before annotated properties
2 participants