Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim multiline text in warnings #322

Merged
merged 3 commits into from
Sep 24, 2020
Merged

Conversation

petertrr
Copy link
Member

What's done:

  • Changed logic in Warnings.kt

This pull request closes #257

### What's done:
* Changed logic in Warnings.kt
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #322 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #322      +/-   ##
============================================
+ Coverage     82.36%   82.38%   +0.02%     
- Complexity      999     1000       +1     
============================================
  Files            51       51              
  Lines          2575     2578       +3     
  Branches        808      809       +1     
============================================
+ Hits           2121     2124       +3     
  Misses          169      169              
  Partials        285      285              
Flag Coverage Δ Complexity Δ
#unittests 82.38% <100.00%> (+0.02%) 1000.00 <0.00> (+1.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...tlin/org/cqfn/diktat/ruleset/constants/Warnings.kt 96.66% <100.00%> (+0.11%) 9.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b33011...ea2b450. Read the comment docs.

Copy link
Collaborator

@kentr0w kentr0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petertrr petertrr merged commit c7d53a6 into master Sep 24, 2020
@petertrr petertrr deleted the feature/single-line-warnings#257 branch September 24, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid using mutliline freeText in warning messages
2 participants