Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RulesConfigYamlTest #307

Merged
merged 9 commits into from
Sep 23, 2020
Merged

Conversation

kentr0w
Copy link
Collaborator

@kentr0w kentr0w commented Sep 18, 2020

What's done:

Added test for another config

closes #304

Fixme

Check third config file

### What's done:
    Added test for another config
@kentr0w kentr0w added the tests Improve testing label Sep 18, 2020
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@5f142e4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #307   +/-   ##
=========================================
  Coverage          ?   81.31%           
  Complexity        ?      967           
=========================================
  Files             ?       51           
  Lines             ?     2531           
  Branches          ?      793           
=========================================
  Hits              ?     2058           
  Misses            ?      187           
  Partials          ?      286           
Flag Coverage Δ Complexity Δ
#unittests 81.31% <ø> (?) 967.00 <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...g/cqfn/diktat/ruleset/rules/kdoc/KdocFormatting.kt 76.87% <0.00%> (ø) 81.00% <0.00%> (?%)
...in/org/cqfn/diktat/ruleset/rules/WhiteSpaceRule.kt 79.67% <0.00%> (ø) 110.00% <0.00%> (?%)
...n/diktat/ruleset/rules/SingleLineStatementsRule.kt 93.33% <0.00%> (ø) 5.00% <0.00%> (?%)
...cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt 97.56% <0.00%> (ø) 3.00% <0.00%> (?%)
...n/org/cqfn/diktat/ruleset/utils/StringCaseUtils.kt 80.59% <0.00%> (ø) 0.00% <0.00%> (?%)
...eset/utils/indentation/CustomIndentationChecker.kt 100.00% <0.00%> (ø) 1.00% <0.00%> (?%)
...otlin/org/cqfn/diktat/ruleset/utils/StringUtils.kt 89.65% <0.00%> (ø) 0.00% <0.00%> (?%)
...ktat/ruleset/rules/ClassLikeStructuresOrderRule.kt 80.30% <0.00%> (ø) 26.00% <0.00%> (?%)
...tlin/org/cqfn/diktat/ruleset/utils/KotlinParser.kt 87.23% <0.00%> (ø) 18.00% <0.00%> (?%)
...kotlin/org/cqfn/diktat/ruleset/rules/LineLength.kt 87.12% <0.00%> (ø) 74.00% <0.00%> (?%)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f142e4...7857034. Read the comment docs.

### What's done:
    Added tests for third config
Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

### What's done:
   Renamed file in warn
Copy link
Collaborator

@aktsay6 aktsay6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@orchestr7 orchestr7 merged commit 0dfaa06 into master Sep 23, 2020
@petertrr petertrr deleted the bugfix/update-test-config-checker branch September 30, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Improve testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update RulesConfigJsonTest
3 participants