Rule 3.14.2 string template format #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Added rule logic * Added warn and fix test
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
============================================
+ Coverage 82.23% 82.36% +0.13%
- Complexity 990 999 +9
============================================
Files 50 51 +1
Lines 2544 2575 +31
Branches 803 808 +5
============================================
+ Hits 2092 2121 +29
Misses 169 169
- Partials 283 285 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
### What's done: * Fixed bugs
orchestr7
reviewed
Sep 21, 2020
diktat-analysis.yml
Outdated
| typeReferenceLength: '25' # max length of type reference | ||
| - name: REDUNDANT_CURLY_BRACES |
There was a problem hiding this comment.
add description
change names: STRING_TEMPLATE_CURLY_BRACES
STRING_TEMPLATE_QUOTES
petertrr
reviewed
Sep 22, 2020
Comment on lines
34
to
36
| } | ||
|
|
||
| if (node.elementType == SHORT_STRING_TEMPLATE_ENTRY) { |
There was a problem hiding this comment.
Please add comment about why these two ifs cannot be combined in if-else
### What's done: * Fixed bugs
petertrr
reviewed
Sep 23, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/StringTemplateFormatRule.kt
Show resolved
Hide resolved
petertrr
requested changes
Sep 23, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/StringTemplateFormatRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/StringTemplateFormatRule.kt
Outdated
Show resolved
Hide resolved
### What's done: * Fixed bugs
### What's done: * Fixed bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done:
Actions checklist
Closes #301