Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diktat-maven-plugin #286

Merged
merged 31 commits into from
Oct 6, 2020
Merged

diktat-maven-plugin #286

merged 31 commits into from
Oct 6, 2020

Conversation

petertrr
Copy link
Member

@petertrr petertrr commented Sep 14, 2020

What's done:

  • Initial implementation
  • Mojos for checking and fixing
  • Set diktat yml config via plugin property

This pull request closes #261

Fixme:

  • extract parameter descriptions to plugin.xml
  • provide diktat config file as a parameter
  • mojo for fixing
  • fail-fast option (can be done later in separate PR)
  • goal for config generation (can be done later in separate PR)
  • choose ktlint reporter via plugin config (can be done later in separate PR)
  • Update docs with new plugin usage instructions

### What's done:
* Initial POC
@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #286 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #286   +/-   ##
=========================================
  Coverage     82.79%   82.79%           
  Complexity     1182     1182           
=========================================
  Files            58       58           
  Lines          2935     2935           
  Branches        930      930           
=========================================
  Hits           2430     2430           
  Misses          169      169           
  Partials        336      336           
Flag Coverage Δ Complexity Δ
#unittests 82.79% <0.00%> (ø) 1182.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...t/common/config/reader/JsonResourceConfigReader.kt 45.45% <0.00%> (ø) 3.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae6cd81...5810b12. Read the comment docs.

…n-plugin#261

# Conflicts:
#	.github/workflows/diktat_snapshot.yml
### What's done:
* Diktat-maven-plugin
### What's done:
* Further implementation
### What's done:
* Extracted DiktatBaseMojo
* Introduced mojo for fix
### What's done:
* Fixes
@petertrr petertrr changed the title WIP: diktat-maven-plugin diktat-maven-plugin Sep 29, 2020
### What's done:
* Fixes
### What's done:
* Fixes
### What's done:
* Fixes
### What's done:
* Fixes
### What's done:
* Diktat code style applied
### What's done:
* Fixes in functional_tests.yml
### What's done:
* Fixes in functional_tests.yml
### What's done:
* Fixes in functional_tests.yml
…n-plugin#261

# Conflicts:
#	.github/workflows/functional_tests.yml
#	pom.xml
Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partially lgtm, but need some clarification

### What's done:
* Small fixes
### What's done:
* Updated info in README.md
@petertrr petertrr marked this pull request as ready for review October 5, 2020 07:47
@petertrr petertrr merged commit 16594da into master Oct 6, 2020
@petertrr petertrr deleted the feature/diktat-maven-plugin#261 branch October 6, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven plugin: diktat should have it's own maven plugin
2 participants