Check if copyright year is valid #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Added new rule, that checks year of copyright * Added warn test * Added fix test
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
============================================
+ Coverage 81.31% 82.12% +0.81%
- Complexity 966 976 +10
============================================
Files 51 50 -1
Lines 2531 2534 +3
Branches 793 798 +5
============================================
+ Hits 2058 2081 +23
+ Misses 187 169 -18
+ Partials 286 284 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
petertrr
requested changes
Sep 11, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/comments/HeaderCommentRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/comments/HeaderCommentRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/comments/HeaderCommentRule.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter2/HeaderCommentRuleFixTest.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter2/HeaderCommentRuleTest.kt
Outdated
Show resolved
Hide resolved
petertrr
reviewed
Sep 11, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/comments/HeaderCommentRule.kt
Outdated
Show resolved
Hide resolved
### What's done: * Fixed bug
petertrr
reviewed
Sep 14, 2020
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter2/HeaderCommentRuleTest.kt
Show resolved
Hide resolved
diktat-rules/src/test/resources/test/paragraph2/header/CopyrightDifferentYearExpected.kt
Show resolved
Hide resolved
### What's done: * Added lint tests * Remade Generation to validate year
### What's done: * Added lint tests * Remade Generation to validate year
# Conflicts: # diktat-rules/src/main/resources/diktat-analysis.yml
### What's done: * Fixed bugs
petertrr
requested changes
Sep 17, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/generation/Generation.kt
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/generation/Generation.kt
Outdated
Show resolved
Hide resolved
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/comments/HeaderCommentRule.kt
Outdated
Show resolved
Hide resolved
### What's done: * Fixed bugs
petertrr
reviewed
Sep 22, 2020
pom.xml
Outdated
| @@ -325,6 +325,9 @@ | |||
| <groupId>org.jacoco</groupId> | |||
| <artifactId>jacoco-maven-plugin</artifactId> | |||
| <version>0.8.5</version> | |||
| <configuration> | |||
| <excludes>GenerationKt</excludes> | |||
There was a problem hiding this comment.
Turns out I was wrong and it doesn't work like this. Could you investigate further? Maybe, **/GenerationKt.class? Or just **/Generation.kt?
### What's done: * Fixed bugs
petertrr
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which rule and warnings did you add?
Rule checks if the year of copyright is valid. For example: (c) 2019 need to be changed to 2020
Actions checklist
Closes #3