-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added classPath argument to detekt plugin, fixed detected issues #238
Conversation
### What's done: * Edited pom.xml * Edited detekt.yml
### What's done: * Fixed detected code issues
### What's done: * Added compilation to detekt workflow
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
============================================
+ Coverage 81.25% 81.33% +0.07%
- Complexity 957 959 +2
============================================
Files 50 50
Lines 2524 2524
Branches 788 789 +1
============================================
+ Hits 2051 2053 +2
+ Misses 190 187 -3
- Partials 283 284 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…detekt-plugin # Conflicts: # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/FileNaming.kt
### What's done: * Override detekt dependency
### What's done: * Corrected errors
…' into infra/classpath-in-detekt-plugin
### What's done: * Corrected errors
### What's done: * Corrected errors
### What's done: * Specify java and kotlin versions in config
### What's done: * Specify java and kotlin versions in config
### What's done: * Fixing issues
### What's done: * Fixing issues
### What's done: * Fixing issues
### What's done: * Fixing issues
…detekt-plugin # Conflicts: # diktat-common/src/test/kotlin/org/cqfn/diktat/test/ConfigReaderTest.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/kdoc/KdocFormatting.kt # pom.xml
…detekt-plugin # Conflicts: # diktat-common/src/test/kotlin/org/cqfn/diktat/test/ConfigReaderTest.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/kdoc/KdocFormatting.kt # pom.xml
### What's done: * Cleanup
…' into infra/classpath-in-detekt-plugin # Conflicts: # diktat-common/src/test/kotlin/org/cqfn/diktat/test/ConfigReaderTest.kt
…detekt-plugin # Conflicts: # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/FileNaming.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/IdentifierNaming.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt # pom.xml
### What's done: * Fixing discovered issues
### What's done: * Batch mode for maven in CI workflows
### What's done: * Fixing discovered issues
### What's done: * Fixing discovered issues
### What's done: * Fixing discovered issues
### What's done: * Fixing discovered issues
### What's done: * Fixing discovered issues
### What's done: * Removed override for detekt-cli
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/PackageNaming.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
### What's done: * Revert changes in PackageNaming.kt
Additional checks involving type resolution are activated if detekt is aware of classpath. It then involves kotlin compiler to create more complex stuff than just AST. This configuration discovered couple of dozens of unsafe
!!
in our code.Fixme:
there are currently a lot of errors like- solved with detekt version update (?)unresolved reference
in build logs, though everything seems to be working fine.warning: classpath entry points to a non-existent location: C
when path starts withC:\
), but nothing can be done on our side