Implementation of recommendation 3.10 - local variables declaration #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: * Initial implementation * Added tests on checkers * Update rules-config.json and available-rules.md * Edited diktat-kotlin-coding-style-guide-en.md
### What's done: * Initial implementation * More tests * Introduced PsiUtils.kt
### What's done: * Allow initialization by some selected methods
### What's done: * Fixes & refactoring
…ion-3.10#155 # Conflicts: # diktat-rules/src/main/kotlin/generated/WarningNames.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt # diktat-rules/src/main/resources/rules-config.json # info/available-rules.md
### What's done: * More tests & refactoring
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
============================================
- Coverage 81.68% 81.41% -0.28%
- Complexity 927 956 +29
============================================
Files 48 50 +2
Lines 2403 2508 +105
Branches 742 780 +38
============================================
+ Hits 1963 2042 +79
- Misses 173 184 +11
- Partials 267 282 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
orchestr7
reviewed
Sep 13, 2020
orchestr7
reviewed
Sep 14, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt
Outdated
Show resolved
Hide resolved
orchestr7
reviewed
Sep 14, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/identifiers/LocalVariablesRule.kt
Show resolved
Hide resolved
orchestr7
reviewed
Sep 14, 2020
diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/identifiers/LocalVariablesRule.kt
Outdated
Show resolved
Hide resolved
orchestr7
reviewed
Sep 14, 2020
orchestr7
reviewed
Sep 14, 2020
diktat-rules/src/test/kotlin/org/cqfn/diktat/ruleset/chapter3/LocalVariablesWarnTest.kt
Show resolved
Hide resolved
orchestr7
approved these changes
Sep 14, 2020
…ion-3.10#155 # Conflicts: # diktat-rules/src/main/kotlin/generated/WarningNames.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/constants/Warnings.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/rules/DiktatRuleSetProvider.kt # diktat-rules/src/main/kotlin/org/cqfn/diktat/ruleset/utils/AstNodeUtils.kt # diktat-rules/src/main/resources/rules-config.json # info/available-rules.md
### What's done: * Fixes after review
### What's done: * Fixes after review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which rule and warnings did you add?
This pull request closes #155
Actions checklist
Fixme
A lot of limitations when working with AST only.