Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serialVersionUID should be ignored in CONSTANT_UPPERCASE #1849

Merged
merged 2 commits into from
Dec 8, 2023
Merged

serialVersionUID should be ignored in CONSTANT_UPPERCASE #1849

merged 2 commits into from
Dec 8, 2023

Conversation

diphtongue
Copy link
Contributor

What's done:

  • Fixed serialVersionUID, which should be ignored in CONSTANT_UPPERCASE
  • Added warning test

Closes #1847

@diphtongue
### What's done:
b30404e 
- Fixed `serialVersionUID`, which should be ignored in `CONSTANT_UPPERCASE`
- Added warning test

Closes #1847
@codecov Codecov
Copy link

codecov bot commented Dec 8, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (09edb26) 78.45% compared to head (303d656) 78.45%.

Files Patch % Lines
.../diktat/ruleset/rules/chapter1/IdentifierNaming.kt 57.14% 0 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##             master    #1849   +/-   ##
=========================================
  Coverage     78.45%   78.45%           
- Complexity     2439     2442    +3     
=========================================
  Files           133      133           
  Lines          8624     8630    +6     
  Branches       2174     2176    +2     
=========================================
+ Hits           6766     6771    +5     
  Misses          896      896           
- Partials        962      963    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023 •
edited
Loading

JUnit Tests (macOS, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   6m 56s ⏱️ - 1m 11s
1 408 tests +2  1 372 ✔️ +2  36 💤 ±0  0 ❌ ±0 
2 787 runs  +2  2 751 ✔️ +2  36 💤 ±0  0 ❌ ±0 

Results for commit 303d656. ± Comparison against base commit 09edb26.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2023 •
edited
Loading

JUnit Tests (Windows, EnricoMi/publish-unit-test-result-action@v2)

   164 files  ±0     164 suites  ±0   6m 58s ⏱️ -33s
1 408 tests +2  1 391 ✔️ +2  17 💤 ±0  0 ❌ ±0 
2 787 runs  +2  2 770 ✔️ +2  17 💤 ±0  0 ❌ ±0 

Results for commit 303d656. ± Comparison against base commit 09edb26.

♻️ This comment has been updated with latest results.

@diphtongue diphtongue merged commit bffd4ad into master Dec 8, 2023
@diphtongue diphtongue deleted the bugfix/constant-uppercase branch December 8, 2023 13:03
diphtongue added a commit that referenced this pull request Dec 12, 2023
@diphtongue
Revert "serialVersionUID should be ignored in CONSTANT_UPPERCASE (#…
e13733c 
…1849)"

This reverts commit bffd4ad.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orchestr7 orchestr7 orchestr7 left review comments

@kgevorkyan kgevorkyan kgevorkyan approved these changes

@DrAlexD DrAlexD DrAlexD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

serialVersionUID should be ignored in CONSTANT_UPPERCASE
4 participants
@diphtongue @kgevorkyan @DrAlexD @orchestr7