Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NewlinesRule doesn't add line break before } #617

Closed
aktsay6 opened this issue Dec 7, 2020 · 1 comment · Fixed by #650
Closed

NewlinesRule doesn't add line break before } #617

aktsay6 opened this issue Dec 7, 2020 · 1 comment · Fixed by #650
Assignees
Labels
bug Something isn't working

Comments

@aktsay6
Copy link
Collaborator

aktsay6 commented Dec 7, 2020

Describe the bug

NewlinesRule doesn't add line break before }

Expected behavior

fun foo() {
    val diktatExtension = project.extensions.create(DIKTAT_EXTENSION, DiktatExtension::class.java).apply {
    inputs = project.fileTree("src").apply {
        include("**/*.kt")
    }
    reporter = PlainReporter(System.out)
    }
}

Observed behavior

fun foo() {
    val diktatExtension = project.extensions.create(DIKTAT_EXTENSION, DiktatExtension::class.java).apply {
    inputs = project.fileTree("src").apply {
        include("**/*.kt")
    }
    reporter = PlainReporter(System.out)}
}

Environment information

  • diktat version: 0.1.6-SNAPSHOT
@aktsay6 aktsay6 added the bug Something isn't working label Dec 7, 2020
@aktsay6 aktsay6 self-assigned this Dec 7, 2020
@petertrr
Copy link
Member

petertrr commented Dec 7, 2020

Please specify when diktat version is not yet released, e.g. 0.1.6-SNAPSHOT or something similar.

aktsay6 added a commit that referenced this issue Dec 17, 2020
### What's done:
  * Logic began
aktsay6 added a commit that referenced this issue Dec 17, 2020
### What's done:
  * Added case for right brace
aktsay6 added a commit that referenced this issue Dec 17, 2020
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Dec 17, 2020
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Dec 21, 2020
### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Dec 21, 2020
* bugfix/newline-rule-rbrace(#617)

### What's done:
  * Fixed bugs
aktsay6 added a commit that referenced this issue Dec 21, 2020
### What's done:
  * Fixed bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants