WRONG_OVERLOADING_FUNCTION_ARGUMENTS: adding exceptions to the rule

### What's done: - rule will be triggered if and only if it has same modifiers
saveourtool · Sep 14, 2022 · 43324e9 · 43324e9
1 parent 7fe9d8f
commit 43324e9
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/...es/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter5/OverloadingArgumentsFunction.kt b/...es/src/main/kotlin/org/cqfn/diktat/ruleset/rules/chapter5/OverloadingArgumentsFunction.kt
@@ -52,10 +52,13 @@ class OverloadingArgumentsFunction(configRules: List<RulesConfig>) : DiktatRule(
     /**
      * We can raise errors only on those methods that have same modifiers (inline/public/etc.)
      */
-    private fun KtFunction.hasSameModifiers(other: KtFunction): Boolean = this.modifierList?.node?.getChildren(KtTokens.MODIFIER_KEYWORDS)
-        ?.sortedBy { it.text } ==
-            other.modifierList?.node?.getChildren(KtTokens.MODIFIER_KEYWORDS)
-                ?.sortedBy { it.text }
+    private fun KtFunction.hasSameModifiers(other: KtFunction) =
+        this.modifierList?.node?.getChildren(KtTokens.MODIFIER_KEYWORDS)
+            ?.map { it.text }
+            ?.sortedBy { it } ==
+                other.modifierList?.node?.getChildren(KtTokens.MODIFIER_KEYWORDS)
+                    ?.map { it.text }
+                    ?.sortedBy { it }
 
     /**
      * we need to compare following things for two functions: