-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: various issues after ent refactor #75
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mircearoata
commented
Jun 24, 2024
- check for either the email or oauth ID matching when logging in
- in production, logging in was checking if either the email or oauth ID were matching an existing user
- I changed my email default github email since signing up, so checking that both are equal would not allow me to sign in
- if checking for both being equal, no account linking would be possible, and the unique email address constraint would also error when logging in with the same email from a different oauth provider
- reindexing mod files was endlessly fetching the 101-200 mods, instead of using the current offset
- query.Clone() discards the effects of Modify, so we take the embedded struct instead, which contains the wanted effects of Modify
- this was also causing the custom last version date ordering to not have any effect
- build custom predicates that contain arguments with ent methods
- ent uses PREPARE, and postgres doesn't seem to support question mark arguments in those, even though their docs show that as an example
- query tags in usermod.Mod resolver
- it's queried on the user page, and the tags field was null, even though the GQL schema specifies a non-null array
- not really a permanent fix, as there are other places that return a Mod but don't query its tags, resulting in a null tags array
- don't return an error in the dataloader when a mod has no versions, or a version has no dependencies
- check and update existing UserMod entries
- previously, each authr entry in the updateMod attempted to create a new UserMod entry, which errored because of the unique index
Vilsol
approved these changes
Jun 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #75 +/- ##
===========================================
- Coverage 17.06% 15.96% -1.11%
===========================================
Files 102 234 +132
Lines 5374 59523 +54149
===========================================
+ Hits 917 9502 +8585
- Misses 4356 47975 +43619
- Partials 101 2046 +1945 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.