Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: acr tests refactor prototype (PSKD-1363) #442

Merged
merged 4 commits into from
Feb 26, 2025

Conversation

illianov
Copy link
Contributor

This PR contains the acr_test.go refactoring using the test table framework we've developed to support the terratests. The refactored tests are in the sister file, acr_new_test.go. This PR is meant to serve as a comparison to other table test implementations for the Acr tests refactoring.

@saschjmil saschjmil changed the base branch from main to pr-pskd-1145 February 26, 2025 15:34
Copy link

@saschjmil saschjmil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow failed due to an rbac test in the old rbac_test.go file, but that doesn't impact these changes. Looks good 👍

@illianov illianov marked this pull request as ready for review February 26, 2025 21:03
@illianov illianov merged commit 1985f13 into pr-pskd-1145 Feb 26, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants