feat: Refactor ACR tests (PSKD-1400) #440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephesused
reviewed
Feb 25, 2025
test/acr_test.go
Outdated
| return &StringContainsTestCase{ | ||
| expected: name, | ||
| path: []string{"azurerm_container_registry.acr[0]", "{$.name}"}, | ||
| message: "ACR name does not contain 'acr'", |
There was a problem hiding this comment.
Nit: Instead of 'acr', this message should use the value of name.
ephesused
reviewed
Feb 25, 2025
test/test_case.go
Outdated
| func getExpectedFromPlan(plan *terraform.PlanStruct, path []string, expectedType string) (any, error) { | ||
| valuesMap := plan.ResourcePlannedValuesMap[path[0]] | ||
|
|
||
| if expectedType == "string" { |
There was a problem hiding this comment.
Non-blocking: Maybe swap to a switch and use an enum for these types.
DCO Remediation Commit for [email protected] <[email protected]> I, [email protected] <[email protected]>, hereby add my Signed-off-by to this commit: 0b2e1ce Signed-off-by: [email protected] <[email protected]>
ndickens
temporarily deployed
to
terraformSecrets
GitHub Actions
Inactive
DCO Remediation Commit for [email protected] <[email protected]> I, [email protected] <[email protected]>, hereby add my Signed-off-by to this commit: 0b2e1ce Signed-off-by: [email protected] <[email protected]>
ndickens
temporarily deployed
to
terraformSecrets
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to add some functionality to the test cases to:
To that end I refactored TestCase to be an interface. A test could run a collection of test cases that would all implement RunTest and the underlying test type would inform how data is retrieved and verified. If there isn't a test type that suits your need then just create a new one and implement its RunTest. getExpectedFromPlan() can also be modified and extended to be able to look in different sections of the plan struct as needed.
Feedback is welcome.