-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: (PSKD-1352) add azure netapp tests #435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Dominno <[email protected]>
saschjmil
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
saschjmil
added a commit
that referenced
this pull request
Mar 4, 2025
* feat: (PSKD-1145) Add initial plan tests Signed-off-by: chjmil <[email protected]> * feat: (PSKD-1145) WIP defaults unit tests Created by Griffin Signed-off-by: chjmil <[email protected]> * more work on default tests Signed-off-by: chjmil <[email protected]> * Finished general variables for defaults Signed-off-by: chjmil <[email protected]> * Restoring go:build tag Signed-off-by: chjmil <[email protected]> * chore(deps): update default vm generations off v3 (#417) * chore(deps): update default vm generations off v3 Signed-off-by: Carus Kyle <[email protected]> * docs: update examples default vm generations from _v3 to _v5 Signed-off-by: Carus Kyle <[email protected]> * fix: flex server v5 to v3 Reverting the flex server from v5 to v3 to make it more generally available. Signed-off-by: chjmil <[email protected]> --------- Signed-off-by: Carus Kyle <[email protected]> Signed-off-by: chjmil <[email protected]> Co-authored-by: chjmil <[email protected]> * Adding additional node pool tests Signed-off-by: chjmil <[email protected]> * Finished NodePools tests * Finished NodePools tests * Rework node pool checking Signed-off-by: chjmil <[email protected]> * Finished Additional Node Pool testing Signed-off-by: chjmil <[email protected]> * fix: explicitly install terraform in linter Signed-off-by: chjmil <[email protected]> * Finished testing for Networking Variables * Updated tfvars file path * Add two more tests using RawPlan Signed-off-by: chjmil <[email protected]> * Add two networking tests Signed-off-by: chjmil <[email protected]> * Add cluster_egress_type test Signed-off-by: chjmil <[email protected]> * test: (PSKD-1271) create test for fips_enabled * Finished testing Networking Variables * Finished testing Networking Variables * Make temp file OS-independent Signed-off-by: chjmil <[email protected]> * Combine network tests and gitignore .vscode Signed-off-by: chjmil <[email protected]> * ci: (PSKD-1310) add git leaks pre commit hook Signed-off-by: Ian Dominno <[email protected]> * feat: add storage_type and nfs tests test storage_type test create_nfs_public_ip test enable_nfs_public_static_ip Signed-off-by: Griffin Tomaszewski <[email protected]> * feat: Add terratest workflow Signed-off-by: chjmil <[email protected]> * fix: secret -> env Signed-off-by: chjmil <[email protected]> * fix: update workflow env Signed-off-by: chjmil <[email protected]> * intentional failure Signed-off-by: chjmil <[email protected]> * Update nodepool_test.go * Add parse_results.go Signed-off-by: chjmil <[email protected]> * fix parse_results Signed-off-by: chjmil <[email protected]> * remove failure printing Signed-off-by: chjmil <[email protected]> * Remove dummy failure Signed-off-by: chjmil <[email protected]> * Fix exit code Signed-off-by: chjmil <[email protected]> * feat: Add prefix test (PSKD-1263) (#430) Co-authored-by: [email protected] <[email protected]> * move acr_test.go and tidy up Signed-off-by: chjmil <[email protected]> * fix go setup cache warning Signed-off-by: chjmil <[email protected]> * test: (PSKD-1264) add location terratest Signed-off-by: Ian Dominno <[email protected]> * test: (PSKD-1275) and (PSKD-1265) Tests the default values for both the rbac_add_enabled and nfs_vm_admin variables. Signed-off-by: joboon <[email protected]> * fix: update plan test workflow name Signed-off-by: chjmil <[email protected]> * fix: temp failure to test workflow Signed-off-by: chjmil <[email protected]> * fix: remove expected failure Signed-off-by: chjmil <[email protected]> * test: add test for nfs_vm_machine_type default (PSKD-1276) (#431) * test: add test for nfs_vm_machine_type default (PSKD-1276) * test: sign-off previous commit (PSKD-1276) DCO Remediation Commit for Ed Overton <[email protected]> I, Ed Overton <[email protected]>, hereby add my Signed-off-by to this commit: 4f1e72c Signed-off-by: Ed Overton <[email protected]> --------- Signed-off-by: Ed Overton <[email protected]> * test: add tests for nfs_raid_disk_type, nfs_raid_disk_size (PSKD-1278)(PSKD-1279) - add test for nfs_raid_disk_type - add test for nfs_raid_disk_size Signed-off-by: David.Houck <[email protected]> * test: (PSKD-1277) terratest test for nfs_vm_zone Signed-off-by: Ian Dominno <[email protected]> * feat: Add ACR tests (PSKD-1353) (#433) * feat: Add ACR tests (PSKD-1353) * feat: Add ACR tests (PSKD-1353) * feat: Add ACR tests (PSKD-1353) --------- Co-authored-by: [email protected] <[email protected]> * Completed 9 variables * Tested all the variables * Tested all the Variables * tested * test: (PSKD-1352) add azure netapp tests (#435) Signed-off-by: Ian Dominno <[email protected]> * test: rbac tests using jsonpath (PSKD-1378) (#436) * test: rbac tests using jsonpath (PSKD-1378) * test: sshkey test refactor (PSKD-1378) * test: refactor acr_test * test: nuke the build tags * test: run all tests * test: testy stuff * test: testy stuff * Tested all the Variables * ci: update helpers and fix some errors Signed-off-by: chjmil <[email protected]> * fix: update go.mod and go.sum Signed-off-by: chjmil <[email protected]> * fix: fix remaining tests Signed-off-by: chjmil <[email protected]> * test: nodetest and postgres tests with jsonpath * test: table test framework (PSKD-1363) * test: add helper for plan vars (PSKD-1363) * test: move some tests to table (PSKD-1363) * Added * test: move rbac_add_enabled to test table (PSKD-1391) Signed-off-by: joboon <[email protected]> * added nodepool to test table * test: acr tests refactor prototype (PSKD-1363) * test: enable dynamic name (PSKD-1363) * changes to nodepool test table * test: message support added for assert failures (PSKD-1363) * test: (PSKD-1397) and (PSKD-1393) Refactors additional nodepool attribute tests for the default plan to use test tables. Included in these attributes are the tests for fips_enabled in PSKD-1393. Signed-off-by: joboon <[email protected]> * docs: (PSKD-1390) convert default required value location to table tests Signed-off-by: Ian Dominno <[email protected]> * test: refactor azure netapp into test table (PSKD-1399) Also refactors non-default RBAC tests into a test table. * test: Convert Default Storage and NFS Server var group to table tests (PSKD-1398) Signed-off-by: David.Houck <[email protected]> * Merge testing into pr-pskd-1145 (#443) * added networking variables table test * changed function to TestPlanNetwork --------- Co-authored-by: Chris Miller <[email protected]> * test: refactor postgres tests into test table (PSKD-1401) * test: add general and output tests (#444) Signed-off-by: chjmil <[email protected]> * test: move admin access tests to table (PSKD-1392) * test: add subnet tests Signed-off-by: chjmil <[email protected]> * test: consolidate testing files (#445) * test: consolidate testing files Signed-off-by: Ian Dominno <[email protected]> * fix: remove parent temp folder Signed-off-by: chjmil <[email protected]> * fix: make file deletion os-agnostic Signed-off-by: chjmil <[email protected]> --------- Signed-off-by: Ian Dominno <[email protected]> Signed-off-by: chjmil <[email protected]> Co-authored-by: chjmil <[email protected]> * test: update admin tests (PSKD-1392) * ci: add testing dockerfile and documentation (#441) * add dockerfile/compose.yml * feat: add dockerfile and docker compose Signed-off-by: chjmil <[email protected]> * feat: change terratest dockerfile implementation Signed-off-by: chjmil <[email protected]> * fix: update workflow Signed-off-by: chjmil <[email protected]> * fix: remove mount Signed-off-by: chjmil <[email protected]> * feat: update docker env params Signed-off-by: chjmil <[email protected]> * fix: (PSKD-1361) install terratest_log_parser) Signed-off-by: Ian Dominno <[email protected]> * fix: (PSKD-1361) remove cp step from terratest_log_parser Signed-off-by: Ian Dominno <[email protected]> * fix: (PSKD-1361) add test results output Signed-off-by: Ian Dominno <[email protected]> * feat: add terratest dockerfile input handling Signed-off-by: chjmil <[email protected]> * test: add failing test for workflow Signed-off-by: chjmil <[email protected]> * fix: remove expected failure Signed-off-by: chjmil <[email protected]> * docs: first pass at terratest log Signed-off-by: chjmil <[email protected]> * test: update workflow results Signed-off-by: chjmil <[email protected]> * ci: update results Signed-off-by: chjmil <[email protected]> * ci: verbose Signed-off-by: chjmil <[email protected]> * ci: fix logging location Signed-off-by: chjmil <[email protected]> * ci: fix part 2 Signed-off-by: chjmil <[email protected]> * revert: remove junit testing Signed-off-by: chjmil <[email protected]> * docs: update terratest dockerfile documentation Signed-off-by: chjmil <[email protected]> * docs: (PSKD-1388) update CONTRIBUTING.md Signed-off-by: Ian Dominno <[email protected]> * ci: update workflow to use verbose Signed-off-by: chjmil <[email protected]> * docs: add testing philosophy Signed-off-by: chjmil <[email protected]> * update go.sum and go.mod Signed-off-by: chjmil <[email protected]> * remove docker compose file Signed-off-by: chjmil <[email protected]> * fix: update default values in entrypoint script * docs: move testing philosophy to docs folder Signed-off-by: chjmil <[email protected]> * docs: terratest_log_parser info to TerratestDockerusage.md Signed-off-by: Ian Dominno <[email protected]> * docs: fix typo Signed-off-by: chjmil <[email protected]> * docs: fix formatting; remove unused parameter Signed-off-by: chjmil <[email protected]> * docs: add section about adding unit tests Signed-off-by: chjmil <[email protected]> * Experimental dockerfile change Signed-off-by: chjmil <[email protected]> * Update workflow Signed-off-by: chjmil <[email protected]> * fix working directory Signed-off-by: chjmil <[email protected]> * Fix workflow file Signed-off-by: chjmil <[email protected]> * test: add Makefile for tests Signed-off-by: Griffin Tomaszewski <[email protected]> * docs: add quotes around $(pwd) Signed-off-by: chjmil <[email protected]> * docs: various fixes Signed-off-by: chjmil <[email protected]> * docs: fix spacing on volume mounts Signed-off-by: chjmil <[email protected]> --------- Signed-off-by: chjmil <[email protected]> Signed-off-by: Ian Dominno <[email protected]> Signed-off-by: Griffin Tomaszewski <[email protected]> Co-authored-by: Griffin Tomaszewski <[email protected]> Co-authored-by: Ian Dominno <[email protected]> * docs: add copyright Signed-off-by: chjmil <[email protected]> --------- Signed-off-by: chjmil <[email protected]> Signed-off-by: Carus Kyle <[email protected]> Signed-off-by: Ian Dominno <[email protected]> Signed-off-by: Griffin Tomaszewski <[email protected]> Signed-off-by: joboon <[email protected]> Signed-off-by: Ed Overton <[email protected]> Signed-off-by: David.Houck <[email protected]> Co-authored-by: chjmil <[email protected]> Co-authored-by: Carus Kyle <[email protected]> Co-authored-by: Phani kumar Thodupunoori <[email protected]> Co-authored-by: Phkuma <[email protected]> Co-authored-by: Vincent Illiano <[email protected]> Co-authored-by: Ian Dominno <[email protected]> Co-authored-by: Griffin Tomaszewski <[email protected]> Co-authored-by: Phkuma <38486220+PhanikumarThodupunoori@users.noreply.github.com> Co-authored-by: Nathaniel Dickens <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: John Boone <[email protected]> Co-authored-by: Ed Overton <[email protected]> Co-authored-by: David.Houck <[email protected]> Co-authored-by: Ian Dominno <[email protected]> Co-authored-by: Kyle Hia <[email protected]> Co-authored-by: kylhia <[email protected]> Co-authored-by: Chris Miller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.