fix(transparency): fix issue #26 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make sure that terminals with opacity are turned into no transparency - make sure that the ubuntu case with transparent blury shadow around is still works - remove the `-trim` option of convert on the effect application that missbehaves even for same colored regions
sassman
force-pushed
the
fix/xmonad-issue-26
branch
from
390515b to
4ceb6f7
Compare
…eak on headless ci builds - also add some more assertions regarding the transparency cropping
…ssue on macos - refactor how transparency is identified into a dedicated function - refactor crop into a dedicated function - write some tests that work with some test data (frames) - refactor feature gate name for all tests that need a real display to `e2e_tests` - remove all unused frames that are not used in tests
sassman
force-pushed
the
fix/xmonad-issue-26
branch
from
5cfc368 to
382ccc6
Compare
sassman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #26 and incluses:
-trimoption of convert on the effect application that missbehaves even for same colored regions