This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
gaze.watched returns an object #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it returns an object, we need to run through the keys, a simple index of isn't enough. This should fix sass#2139
nschonni
approved these changes
Nov 9, 2017
Merged
xzyfer
reviewed
Nov 9, 2017
bin/node-sass
Outdated
| gaze.add(file); | ||
| } | ||
| Object.keys(watch).forEach(function (dir) { | ||
| if (watch[dir].indexOf(file)) { |
There was a problem hiding this comment.
Looks like you inverted this behaviour? Should it be
if (watch[dir].indexOf(file) !== -1) {There was a problem hiding this comment.
Thank you! Yes, I totally messed that up when I refactored (in gaze's code where I copied it from, it was set to a variable first). Will fix that right away.
replaces the check I removed in refactoring.
saper
added a commit
that referenced
this pull request
Nov 11, 2017
## Fixes - Problem with watcher (@evanfuture, #2147) ## Supported Environments | OS | Architecture | Node | | --- | --- | --- | | Windows | x86 & x64 | 0.10, 0.12, 1, 2, 3, 4, 5, 6, 7, 8, 9 | | OSX | x64 | 0.10, 0.12, 1, 2, 3, 4, 5, 6, 7, 8, 9 | | Linux* | x86 & x64 | 0.10, 0.12, 1, 2, 3, 4, 5, 6, 7, 8, 9 | | Alpine | x64 | 4, 6, 7, 8, 9 | | FreeBSD 10+ | i386 | 4, 6, 8 | | FreeBSD 10+ | amd64 | 4, 6, 8 | *Linux support refers to Ubuntu, Debian, and CentOS 5
|
@saper looks good 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it returns an object, we need to run through the keys, a simple index of isn't enough. This should fix #2139