Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Node 9 support (module 59) #2129

Closed
8 tasks done
nschonni opened this issue Oct 31, 2017 · 9 comments
Closed
8 tasks done

Node 9 support (module 59) #2129

nschonni opened this issue Oct 31, 2017 · 9 comments
Assignees
Labels

Comments

@nschonni
Copy link
Contributor

nschonni commented Oct 31, 2017

Preemptivly opening this issue since Node 9 was released today. We'll use this issue to track adding the support and close other issues.

Install version 4.6.0+ for Node 9 support

@stefanpenner
Copy link
Contributor

is this fixed by: #2130 ?

@xzyfer
Copy link
Contributor

xzyfer commented Nov 2, 2017 via email

@nschonni
Copy link
Contributor Author

nschonni commented Nov 3, 2017

4.6.0 has been released with support for node 9 https://github.com/sass/node-sass/releases/tag/v4.6.0
There are bindings for Alpine and FreeBSD still missing, but they will just be attached to the release

@sass sass deleted a comment from xnnkmd Nov 3, 2017
@sass sass deleted a comment from graingert Nov 3, 2017
@sass sass deleted a comment from depsypher Nov 3, 2017
@sass sass deleted a comment from SomethingNew71 Nov 3, 2017
@sass sass deleted a comment from Burhan1991 Nov 3, 2017
@sass sass deleted a comment from mrgrotts Nov 3, 2017
@sass sass deleted a comment from nschonni Nov 3, 2017
@LaurentGoderre
Copy link
Contributor

How do you get Alpine working? I'm really curious

@nschonni
Copy link
Contributor Author

nschonni commented Nov 6, 2017

@LaurentGoderre info is over in #1996 in the linked repo. Should add some compose files though, but I never finished them up

@LaurentGoderre
Copy link
Contributor

Aah so it's sort of a sneaky way! a good one though

@saper
Copy link
Member

saper commented Nov 7, 2017

Strange, I encounter this error when trying to npm install --ignore-scripts on FreeBSD node 9.x:

/usr/local/bin/node[8979]: ../src/node_zlib.cc:430:static void node::<anonymous namespace>::ZCtx::Init(const FunctionCallbackInfo<v8::Value> &):
Assertion `args.Length() == 7 &&
   "init(windowBits, level, memLevel, strategy, writeResult, writeCallback," " dictionary)"' failed.
*** Signal 6

Looks quite similar to nodejs/node#13082

@nschonni
Copy link
Contributor Author

Locking this as the only outstanding issue is FreeBSD binaries.

@sass sass locked and limited conversation to collaborators Dec 18, 2017
@xzyfer xzyfer closed this as completed Mar 8, 2018
@saper
Copy link
Member

saper commented Mar 11, 2018

Yep, uploaded for 4.7.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants