Windows binaries for v2.0.0

[am11]

Updated (12.02.2015)

• Windows: Adds binary for v2.0.0.
• node.js v0.10 ia32.
• node.js v0.10 x64.
• node.js v0.12 ia32.
• node.js v0.12 x64.
• io.js v0.12 ia32.
• io.js v0.12 x64.

//cc sass/node-sass#655

[am11]

@andrew, would you please add the Mac binary for v2? 😺

[andrew]

@am11 I've built the binary but when running the tests I get the following:

andrews-mbp-2:node-sass andrew$ npm test

> [email protected] pretest /Users/andrew/code/node-sass
> jshint bin lib test


> [email protected] test /Users/andrew/code/node-sass
> mocha test



  api
    .render(options)
      ✓ should compile sass to css with file 
      ✓ should compile sass to css with data 
      ✓ should compile sass to css using indented syntax 
      ✓ should throw error status 1 for bad input 
      ✓ should compile with include paths 
      ✓ should compile with image path 
      ✓ should throw error with non-string image path 
      ✓ should render with --precision option 
      ✓ should contain all included files in stats when data is passed 
    .render(importer)
Abort trap: 6

I can take a look at it this evening, can you remind me of the steps to debug it?

[am11]

@andrew, this is basically a known issue: sass/node-sass#586. I made some fixes for Linux and Win but couldn't figure out what is going wroyng on OSX by the logs posted by OP.

To reproduce, run the following in node-sass repo's root:

require("./").render({
    data: "@import \"non-existing-file\"; \n.test {\ncolor: #000;\n}",
    outputStyle: 'compressed',
    success: function(result) {
        console.log(result);
    },
    error: function(error) {
        console.log(error);
    },
    importer: function(url, prev, done) {
        done({contents: 'div { color: #000; }'});
    }
});

I think the minimal code to reproduce would be:

require("./").render({
    data: "@import \"non-existing-file\"; \n.test {\ncolor: #000;\n}",
    importer: function(url, prev, done) {
        done({contents: 'div { color: #000; }'});
    }
});

However, changing render to renderSync would probably pass.

To debug, I used the following approaches:

• gdb /usr/bin/node node_modules/.bin/mocha test
  • this will attach the debugger while running the tests.
• strace -Ff -tt /usr/bin/node node_modules/.bin/mocha test 2>&1 | tee /tmp/strace-node-sass.log
  • provided you have strace installed
  • This will generate a verbose log file: /tmp/strace-node-sass.log. Example
• G_SLICE=always-malloc G_DEBUG=gc-friendly valgrind -v --tool=memcheck --leak-check=full --show-reachable=yes --num-callers=40 --log-file=/tmp/valgrind.log $(which node) node_modules/.bin/mocha test
  • provided you have valgrind installed
  • this will generate the log file /tmp/valgrind.log. This is mostly used to detect memory leaks and other memory related issues. Example

I think it is happening somewhere here, where the next function to be executed is dispatched_async_uv_callback.

[andrew]

I'm totally swamped with freelance work at the moment, not going to have any time to debug this at the moment, sorry.

[am11]

Its totally alright. I know the feeling. I think this importer might not be fixed for OSX in the next release. But we can wait a little longer, since @xzyfer may look into it soon. :)

[xzyfer]

This is a month old, is this still relevant, should it be regenerated?

[am11]

Once Linux binaries are ready, I will rebuild for Windows and repush to this PR.