-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove validateO1Specific #939
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #939 +/- ##
==========================================
+ Coverage 98.46% 98.86% +0.40%
==========================================
Files 24 27 +3
Lines 1364 1765 +401
==========================================
+ Hits 1343 1745 +402
+ Misses 15 14 -1
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Thanks for this work - I added that function but didn't know this was true at the time 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Hey folks, what's the plan/timeline to release this? is there anything we can help? |
* fix: remove validateO1Specific * update golangci-lint-action version * fix actions * fix actions * fix actions * fix actions * remove some o1 test
In the latest openai o1 release o1-2024-12-17, Function calling is supported, and I test that system roles can be passed
see: https://openai.com/index/o1-and-new-tools-for-developers/