Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove validateO1Specific #939

Merged
merged 7 commits into from
Feb 17, 2025
Merged

Conversation

liushuangls
Copy link
Contributor

In the latest openai o1 release o1-2024-12-17, Function calling is supported, and I test that system roles can be passed

see: https://openai.com/index/o1-and-new-tools-for-developers/

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.86%. Comparing base (774fc9d) to head (aa8f408).
Report is 85 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #939      +/-   ##
==========================================
+ Coverage   98.46%   98.86%   +0.40%     
==========================================
  Files          24       27       +3     
  Lines        1364     1765     +401     
==========================================
+ Hits         1343     1745     +402     
+ Misses         15       14       -1     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rorymalcolm
Copy link
Contributor

In the latest openai o1 release o1-2024-12-17, Function calling is supported, and I test that system roles can be passed

see: https://openai.com/index/o1-and-new-tools-for-developers/

Thanks for this work - I added that function but didn't know this was true at the time 🙏

Copy link
Owner

@sashabaranov sashabaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sashabaranov sashabaranov merged commit 85f578b into sashabaranov:master Feb 17, 2025
3 checks passed
@liushuangls liushuangls deleted the dev branch February 18, 2025 01:48
@kanwang
Copy link

kanwang commented Feb 25, 2025

Hey folks, what's the plan/timeline to release this? is there anything we can help?
this has introduced regression when we tried to upgrade to 1.37.0. so seems worth pushing for a release sooner.

sunhailin-Leo pushed a commit to sunhailin-Leo/go-openai that referenced this pull request Feb 25, 2025
* fix: remove validateO1Specific

* update golangci-lint-action version

* fix actions

* fix actions

* fix actions

* fix actions

* remove some o1 test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants