-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add File purposes as constants #577
Add File purposes as constants #577
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #577 +/- ##
=======================================
Coverage 98.38% 98.38%
=======================================
Files 24 24
Lines 1300 1300
=======================================
Hits 1279 1279
Misses 15 15
Partials 6 6 ☔ View full report in Codecov by Sentry. |
Thanks! I've rebased your merged changes in to this PR. Looks like we still need two more purposes added. @sashabaranov This is ready for review 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
* Add purposes. * Formatting.
Describe the change
File
, you need to define a.Purpose
string
that is passed to theFileRequest
typeDescribe your solution
Add a constant for each supported purpose as defined in the OpenAI API.
Tests
No tests needed.
Additional context
Not related to an issue, just something I saw when using the new Assistants API.