feat: make finish reason nullable in json marshal #449
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
this PR added a
MarshalJSON
toFinishReason
.Describe your solution
MarshalJSON
implementedMarshaler
interface in packageencoding/json
If
FinishReason
isFinishReasonNull
or empty string, we can render it asnull
instead of"null"
.Tests
Since i am not sure is this PR expected, i didn't add a lot of test cases in *_test.go file in the PR. but it was test locally.