Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move marshaller and unmarshaler into internal pkg (#304) #325

Conversation

vvatanabe
Copy link
Collaborator

Fix #304 (marshaller and unmarshaler.)

@vvatanabe vvatanabe force-pushed the move-marshaller-and-unmarshaler-into-internal-pkg-304 branch from a89eae0 to de71388 Compare May 26, 2023 00:35
@vvatanabe vvatanabe force-pushed the move-marshaller-and-unmarshaler-into-internal-pkg-304 branch from de71388 to dfcada8 Compare May 26, 2023 00:37
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #325 (dfcada8) into master (a18c18d) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
- Coverage   92.41%   92.36%   -0.05%     
==========================================
  Files          21       19       -2     
  Lines         659      655       -4     
==========================================
- Hits          609      605       -4     
  Misses         37       37              
  Partials       13       13              
Impacted Files Coverage Δ
chat_stream.go 89.28% <100.00%> (ø)
error_accumulator.go 100.00% <100.00%> (ø)
request_builder.go 100.00% <100.00%> (ø)
stream.go 90.62% <100.00%> (ø)
stream_reader.go 89.18% <100.00%> (ø)

@vvatanabe
Copy link
Collaborator Author

@sashabaranov Please check it.

Copy link
Owner

@sashabaranov sashabaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! 🙌🏻

@sashabaranov sashabaranov merged commit 62eb4be into sashabaranov:master May 28, 2023
@vvatanabe vvatanabe deleted the move-marshaller-and-unmarshaler-into-internal-pkg-304 branch May 28, 2023 03:44
@vvatanabe vvatanabe restored the move-marshaller-and-unmarshaler-into-internal-pkg-304 branch May 28, 2023 03:47
@vvatanabe vvatanabe deleted the move-marshaller-and-unmarshaler-into-internal-pkg-304 branch May 28, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move some code into internal directory
2 participants