Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify README.md files and unit tests #2

Conversation

ZhuXiaoBing-cn
Copy link

Modify unit tests
Modify README.md file

Copy link
Owner

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -111,7 +111,7 @@ Please follow [create managed identity][create-managed-identity] to set up manag

##### Update MSI related properties

1. Update [application-mi.yaml](src/main/resources/application-mi.yaml)
1. Update [application-mi.yaml][application-mi.yaml]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if the text is the same as the reference link text, we could use only [application-mi.yaml].

@saragluna saragluna merged commit f2fcab9 into saragluna:storage-identity-remove-resource-manager-provider Dec 18, 2020
saragluna pushed a commit that referenced this pull request May 10, 2023
* health insights sdk for java

* rename country to countryOrRegion

* update product name to azure-health-insights

* update cspell with missing words

* update root pom.xml and version_client.txt

* update dependency versions

* update dependency versions (#2)

* skip jacoco

* fix spell checks

* Asaflevi/feature/healthinsights sdk for java (#3)

* update dependency versions

* skip jacoco

* fix spell checks

* skip jacoco

* linting

* remove redundant plugins

* remove test.yaml files

* remove redundant package.json file

* fix sampes and readmes

* spell

* fix linting

* fix sample repository reference

* remove duplicate dependency (mockito)

* alignment (readme)

* fix readme title

* setPlaybackSyncPollerPollInterval

* update serviceversion class (emitter 0.5.1)

* remove impressions png
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants