Skip to content
This repository was archived by the owner on Apr 25, 2023. It is now read-only.

Ожидаем два возможных формата DateTime для поля DateLastChange #112

Merged
merged 1 commit into from
May 1, 2021
Merged

Ожидаем два возможных формата DateTime для поля DateLastChange #112

merged 1 commit into from
May 1, 2021

Conversation

vladkovch
Copy link
Contributor

@vladkovch vladkovch commented May 1, 2021

Причина изменений описана в #110

Ожидаем два формата в поле DateLastChange:

  • Y-m-d H:i:s

  • Y-m-d H:i:sP

  • Fixes #110

  • Есть покрытие тестами для всех изменений.

  • Весь код отформатирован под стандарт (посредством make или make ci).

  • Интеграционные тесты проходят без ошибок.

  • Нет ошибок при CI при вызове make.

Почему-то получаю ошибку при вызове make 🤷‍♂️,
но она была и до моих изменений, в main ветке:

In CoverageChecker.php line 169:
OK, but incomplete, skipped, or risky tests!
Tests: 266, Assertions: 1046, Skipped: 1.
Issue(s):

  • The file "index.xml" could not be found: Could not find any "index.xml" file in "/home/projects/cdek-sdk/build/logs"

@sanmai sanmai self-requested a review May 1, 2021 15:54
@sanmai sanmai merged commit 97f4388 into sanmai:main May 1, 2021
@vladkovch vladkovch deleted the fix_mixed_datelastchange branch May 1, 2021 17:01
@vladkovch vladkovch restored the fix_mixed_datelastchange branch May 1, 2021 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants