Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure comlink stays connected if navigate changes #2082

Merged
merged 3 commits into from
Nov 4, 2024
Merged

fix: ensure comlink stays connected if navigate changes #2082

merged 3 commits into from
Nov 4, 2024

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Nov 4, 2024

No description provided.

@stipsan stipsan requested a review from a team as a code owner November 4, 2024 13:29
@vercel Vercel
Copy link

vercel bot commented Nov 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
live-visual-editing-next ❌ Failed (Inspect) Nov 4, 2024 1:35pm
visual-editing-astro ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 1:35pm
visual-editing-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 1:35pm
visual-editing-next-with-i18n ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 1:35pm
visual-editing-nuxt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 1:35pm
visual-editing-page-builder-demo ❌ Failed (Inspect) Nov 4, 2024 1:35pm
visual-editing-remix ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 1:35pm
visual-editing-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 1:35pm
visual-editing-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 1:35pm
visual-editing-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 1:35pm

@vercel vercel bot temporarily deployed to Preview – visual-editing-studio November 4, 2024 13:30 Inactive
@stipsan stipsan changed the title Debug corel fix: ensure comlink stays connected if navigate changes Nov 4, 2024
@stipsan stipsan merged commit c9e738d into corel Nov 4, 2024
6 of 17 checks passed
@stipsan stipsan deleted the debug-corel branch November 4, 2024 13:32
stipsan added a commit that referenced this pull request Nov 5, 2024
@stipsan
fix: ensure comlink stays connected if navigate changes (#2082)
ec6d8cd 
* chore: find cause

* fix: handle comlink disconnect

* chore: remove debug code
rdunk pushed a commit that referenced this pull request Nov 6, 2024
@stipsan @rdunk
fix: ensure comlink stays connected if navigate changes (#2082)
b2c7902 
* chore: find cause

* fix: handle comlink disconnect

* chore: remove debug code
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stipsan