fix: if the build step fails release should halt

sanity-io · Nov 4, 2022 · a1bb635 · a1bb635
1 parent f81e2c8
commit a1bb635
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -81,9 +81,9 @@ jobs:
       - run: npm test
 
   release:
-    needs: test
-    # only run if opt-in during workflow_dispatch, and run if tests are skipped using the toggle, but not if they have failed
-    if: always() && github.event.inputs.release == 'true' && needs.test.result != 'failure' && needs.test.result != 'cancelled'
+    needs: [build, test]
+    # only run if opt-in during workflow_dispatch
+    if: always() && github.event.inputs.release == 'true' && needs.build.result != 'failure' && needs.test.result != 'failure' && needs.test.result != 'cancelled'
     runs-on: ubuntu-latest
     name: Semantic release
     steps:

diff --git a/assets/inject/semver-workflow/.github/workflows/main.yml b/assets/inject/semver-workflow/.github/workflows/main.yml
@@ -91,8 +91,9 @@ jobs:
 
   release:
     needs: test
-    # only run if opt-in during workflow_dispatch, and run if tests are skipped using the toggle, but not if they have failed
-    if: always() && github.event.inputs.release == 'true' && needs.test.result != 'failure' && needs.test.result != 'cancelled'
+    needs: [build, test]
+    # only run if opt-in during workflow_dispatch
+    if: always() && github.event.inputs.release == 'true' && needs.build.result != 'failure' && needs.test.result != 'failure' && needs.test.result != 'cancelled'
     runs-on: ubuntu-latest
     name: Semantic release
     steps: