-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade websockets dependency. #2154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aaugustin
If this is all we need for 9 support, then maybe the answer for #2000 is to hold off on inclusion of the sans-io implementation until our September release.
From my perspective as the maintainer of websockets, you can happily live with this for a few years :-) I just need to get the checks to pass! |
I am pulling locally and will push a commit for the linting |
I tried to fix it in the meantime. I'll stop interfering now and leave it up to you! |
No worries. I was trying to make it easier for you. It should be as simple as Thanks again for your help and support. |
I am going to have to hold off on merging this one until I do a release of |
Fix #2142.