Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade websockets dependency. #2154

Merged
merged 3 commits into from
Jun 16, 2021
Merged

Upgrade websockets dependency. #2154

merged 3 commits into from
Jun 16, 2021

Conversation

aaugustin
Copy link
Contributor

Fix #2142.

@aaugustin aaugustin requested review from a team as code owners June 2, 2021 20:11
ahopkins
ahopkins previously approved these changes Jun 2, 2021
Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aaugustin

If this is all we need for 9 support, then maybe the answer for #2000 is to hold off on inclusion of the sans-io implementation until our September release.

@ashleysommer?

@aaugustin
Copy link
Contributor Author

From my perspective as the maintainer of websockets, you can happily live with this for a few years :-)

I just need to get the checks to pass!

@ahopkins
Copy link
Member

ahopkins commented Jun 2, 2021

I just need to get the checks to pass!

I am pulling locally and will push a commit for the linting

@aaugustin
Copy link
Contributor Author

I tried to fix it in the meantime. I'll stop interfering now and leave it up to you!

@ahopkins
Copy link
Member

ahopkins commented Jun 2, 2021

No worries. I was trying to make it easier for you. It should be as simple as make pretty assuming you have black and isort installed. Will wait for the checks to run.

Thanks again for your help and support.

ahopkins
ahopkins previously approved these changes Jun 2, 2021
@ahopkins
Copy link
Member

ahopkins commented Jun 3, 2021

I am going to have to hold off on merging this one until I do a release of sanic-testing to get the websockets v8 req lifted. I think that is why the tests are ending up in resolution hell.

@ahopkins ahopkins merged commit aff6604 into sanic-org:main Jun 16, 2021
@aaugustin aaugustin deleted the upgrade-websockets-9 branch June 16, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow later websockets releases
2 participants