Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade development status to beta #1105

Merged
merged 1 commit into from
Jan 31, 2018
Merged

Upgrade development status to beta #1105

merged 1 commit into from
Jan 31, 2018

Conversation

manisenkov
Copy link
Contributor

Fix for #1103

@r0fls
Copy link
Contributor

r0fls commented Jan 31, 2018

🤔 what's up with these failed tests

@manisenkov
Copy link
Contributor Author

🤷‍♂️ seems not related to changes in this PR

@manisenkov
Copy link
Contributor Author

run tests locally, looks like problem is related to this: pytest-dev/pytest#3170

@r0fls
Copy link
Contributor

r0fls commented Jan 31, 2018

Why did it start out of nowhere though? 🤔 Although I agree it's unrelated, as a policy we don't merge PRs with failed tests...

@manisenkov
Copy link
Contributor Author

I made PR (#1108) with pinned version of pytest: #1108, or one could wait until fix (Teemu/pytest-sugar#133) for pytest-sugar will be released.

@manisenkov
Copy link
Contributor Author

I've rebased PR, now it's 🍏

r0fls
r0fls approved these changes Jan 31, 2018
View reviewed changes
Copy link
Contributor

@r0fls r0fls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@r0fls r0fls merged commit 74efa3a into sanic-org:master Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0fls r0fls r0fls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manisenkov @r0fls