Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

router: Fix missing requirement checks for regex routes #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

router: Fix missing requirement checks for regex routes #53

wants to merge 1 commit into from

Conversation

shizmob
Copy link

@shizmob shizmob commented Jan 4, 2022

Since Node._inject_requirements also injects a method check, it doesn't need to be injected explicitly again.

@ahopkins ahopkins self-requested a review January 4, 2022 21:16
@ahopkins ahopkins self-assigned this Jan 4, 2022
@ahopkins
Copy link
Member

Can you add a unit test for this? I am not sure what case this is trying to solve.

@ahopkins
Copy link
Member

@shizmob?

@ahopkins
Copy link
Member

ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahopkins ahopkins Awaiting requested review from ahopkins

At least 1 approving review is required to merge this pull request.

Assignees

@ahopkins ahopkins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shizmob @ahopkins