Add test for duplicate path url but different methods #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahopkins
requested changes
Jun 29, 2021
tests/test_routing.py
Outdated
| router.add("/<foo:path>", handler2, methods=["POST"]) | ||
| router.finalize() | ||
|
|
||
| _, handler, params = router.get("/a-random-path", "GET") |
There was a problem hiding this comment.
Since we're doing path, can you make the test /a/random/path? Or perhaps even better, maybe parametrize the test and do both a single and multi segment path.
There was a problem hiding this comment.
@ahopkins Just pushed an update. Let me know if it works for you.
robd003
force-pushed
the
catch-path-route-error
branch
from
9daa016 to
922d571
Compare
|
For the routes is it worth marking which methods they support and then when searching for paths to limit the search for current method only? In the test case above I was seeing a matcher overtake an even though the wasn't supposed to respond for the method being requested. |
|
I am not sure I understand the question. The issue is (as you said) that the last route definition is taking priority for the methods |
|
Replaced by #45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for issue #43